more pre-8.0 fixes

CHANGES

@@ -1,9 +1,9 @@
 Changelog for hydra
 -------------------
 
-Release 7.7
+Release 8.0
 * Added module for redis (submitted by Alejandro Ramos, thanks!)
-* Added patch which adds Unicode support for the SMB module (thanks to Max Kosmach")
+* Added patch which adds Unicode support for the SMB module (thanks to Max Kosmach)
 * Added initial interactive password authentication test for ssh (thanks to Joshua Houghton for submitting)
 * Bugfixes for -x option:
   - password tries were lost when connection errors happened (thanks to Vineet Kumar for reporting)
@@ -13,6 +13,7 @@ Release 7.7
 * Added gcc compilation security options (if detected to be supported by configure script)
 * Enhancements to the secure compilation options
 * Checked code with cppcheck and fixed some minor issues. surprised it were so few and unlikely stuff :-)
+* Checked code with Coverity. Fixed a lot of small and medium issues.
 
 
 Release 7.6

TODO

@@ -0,0 +1,36 @@
+Restore Session/s with use This -M command
+
+Prio 1:
+* hydra-oracle support service names (often SIDs do not work anymore)
+* hydra-smb more than 1 connection?
+* add help hints?
+* test teamspeak, icq
+* check all modules to ensure no check is lost because of a timeout, buf == NULL etc.
+* optimize smtp module
+* optimize ssl performance
+* add snmpv3 privacy support
+* http: option to specify an url for testing if the login was right or wrong
+* add missing services to xhydra, e.g. sshkey and s7-300
+
+
+Prio 2:
+* support different ports in the -M input file for each target
+* add support for IPv6 Link Local Addresses like fe80::1%eth0 for Solaris and *BSD
+* add crack info when key is pressed
+* hydra-smb support NTLMv2 (when its fixed)
+* support for 802.1x EAP via libpcap
+* TN3270, and TN3270 user enumeration
+* CIDR support -> hydra -l admin -p test 192.168.0.0/24 smb
+
+
+Prio 3:
+* Specify user-agent for http-form module as extra optional option
+* ipv6 support for sip
+* add RIP, OSPF, BGP, PIM
+* add diameter support
+* round robin proxy support ?
+* clean main dir
+* add support for hybrid pass crack
+* add tn5250 support
+* Add Sybase support, using freetds lib (can be used for ms-sql)
+* Add Informix ?

hydra-cisco.c

@@ -5,7 +5,7 @@
 #endif
 
 extern char *HYDRA_EXIT;
-char *buf;
+char *buf = NULL;
 
 int start_cisco(int s, char *ip, int port, unsigned char options, char *miscptr, FILE * fp) {
   char *empty = "";
@@ -25,6 +25,8 @@ int start_cisco(int s, char *ip, int port, unsigned char options, char *miscptr,
   }
   sleep(1);
   do {
+    if (buf != NULL)
+      free(buf);
     if ((buf = hydra_receive_line(s)) == NULL)
       return 3;
     if (buf[strlen(buf) - 1] == '\n')

hydra-http-proxy-urlenum.c

@@ -80,6 +80,7 @@ int start_http_proxy_urlenum(int s, char *ip, int port, unsigned char options, c
         hydra_report(stderr, "C:%s\n", buffer);
       if (hydra_send(s, buffer, strlen(buffer), 0) < 0)
         return 1;
+      free(buf);
       buf = hydra_receive_line(s);
       while (buf != NULL && strstr(buf, "HTTP/1.") == NULL) {
         free(buf);

hydra-rlogin.c

@@ -39,7 +39,8 @@ int start_rlogin(int s, char *ip, int port, unsigned char options, char *miscptr
     return 4;
   }
   buffer[0] = 0;
-  ret = hydra_recv(s, buffer, sizeof(buffer) - 1);
+  if ((ret = hydra_recv(s, buffer, sizeof(buffer) - 1)) >= 0)
+    buffer[ret] = 0;
   /* 0x00 is sent but hydra_recv transformed it */
   if (strlen(buffer) == 0) {
     ret = hydra_recv(s, buffer, sizeof(buffer) - 1);

performance.h

@@ -34,7 +34,7 @@ ssize_t read_safe(int fd, void *buffer, size_t len) {
   struct timeval tv;
   int ret = 0;
 
-  fcntl(fd, F_SETFL, O_NONBLOCK);
+  (void)fcntl(fd, F_SETFL, O_NONBLOCK);
   do {
     FD_ZERO(&fr);
     FD_SET(fd, &fr);