Python style check.

Author: alejandroautalan

create-imgs.py

@@ -1,5 +1,6 @@
 #!/usr/bin/env python
 from __future__ import print_function
+
 import os
 import sys
 import subprocess
@@ -46,6 +47,7 @@
 IMG_DIR = os.path.join(os.path.dirname(os.path.abspath(__file__)),
         'pygubudesigner', 'images', 'widgets')
 
+
 def create_images():
     origin = os.path.join(IMG_DIR, 'png', '22x22')
     dest = os.path.join(IMG_DIR, '22x22')
@@ -54,7 +56,7 @@ def create_images():
         iimage = os.path.join(origin, f)
         for output in v:
             print('.', end='', flush=True)
-            oimage = os.path.join(dest,output)
+            oimage = os.path.join(dest, output)
             cmd = 'convert {0} {1}.gif'.format(iimage, oimage)
             cmd = shlex.split(cmd)
             subprocess.call(cmd)
@@ -76,7 +78,7 @@ def create_images():
 
 def find_source_image_for(widget_name):
     found = None
-    for k, v in gtk_imgs.iteritems():
+    for k, v in gtk_imgs.items():
         if widget_name in v:
             found = k
             break

pygubu/__init__.py

@@ -1,4 +1,5 @@
 from __future__ import unicode_literals
+
 __all__ = ['Builder', 'TkApplication']
 
 from pygubu.builder import Builder
@@ -51,7 +52,8 @@ def __on_window_close(self):
             self.toplevel.destroy()
 
     def on_close_execute(self):
-        """Determine if if the application is ready for quit, return boolean."""
+        """Determine if if the application is ready for quit,
+           return boolean."""
         return True
 
     def quit(self):

pygubu/builder/__init__.py

@@ -37,9 +37,7 @@
 logging.basicConfig(level=logging.WARNING)
 logger = logging.getLogger('pygubu.builder')
 
-#
-#
-#
+
 def data_xmlnode_to_dict(element, translator=None):
     data = {}
 
@@ -48,7 +46,7 @@ def data_xmlnode_to_dict(element, translator=None):
 
     #properties
     properties = element.findall('./property')
-    pdict= {}
+    pdict = {}
     for p in properties:
         pvalue = p.text
         if translator is not None and p.get('translatable'):
@@ -149,7 +147,7 @@ def data_dict_to_xmlnode(data, translatable_props=None):
                 pnode.set('name', prop)
                 pnode.text = pv
                 layout_node.append(pnode)
-        keys = {'rows':'row', 'columns':'column'}
+        keys = {'rows': 'row', 'columns': 'column'}
         for key in keys:
             if key in layout:
                 erows = ET.Element(key)
@@ -193,12 +191,10 @@ def __init__(self, translator=None):
         self._resource_paths = []
         self.translator = translator
 
-
     def add_resource_path(self, path):
         """Add additional path to the resources paths."""
         self._resource_paths.append(path)
 
-
     def get_image(self, path):
         """Return tk image corresponding to name which is taken form path."""
         image = ''
@@ -213,7 +209,6 @@ def get_image(self, path):
             pass
         return image
 
-
     def __find_image(self, relpath):
         image_path = None
         for rp in self._resource_paths:
@@ -223,19 +218,17 @@ def __find_image(self, relpath):
                 break
         return image_path
 
-
     def get_variable(self, varname):
         """Return a tk variable created with 'create_variable' method."""
         return self.tkvariables[varname]
 
-
     def create_variable(self, varname, vtype=None):
         """Create a tk variable.
         If the variable was created previously return that instance.
         """
 
         var = None
-        type_from_name = 'string' #default type
+        type_from_name = 'string'  # default type
         if ':' in varname:
             type_from_name, varname = varname.split(':')
 
@@ -259,7 +252,6 @@ def create_variable(self, varname, vtype=None):
             self.tkvariables[varname] = var
         return var
 
-
     def add_from_file(self, fpath):
         """Load ui definition from file."""
         if self.tree is None:
@@ -272,7 +264,6 @@ def add_from_file(self, fpath):
             #TODO: append to current tree
             pass
 
-
     def add_from_string(self, strdata):
         """Load ui definition from string."""
         if self.tree is None:
@@ -283,7 +274,6 @@ def add_from_string(self, strdata):
             #TODO: append to current tree
             pass
 
-
     def add_from_xmlnode(self, element):
         """Load ui definition from xml.etree.Element node."""
         if self.tree is None:
@@ -297,7 +287,6 @@ def add_from_xmlnode(self, element):
             #TODO: append to current tree
             pass
 
-
     def get_object(self, name, master=None):
         """Find and create the widget named name.
         Use master as parent. If widget was already created, return
@@ -317,14 +306,12 @@ def get_object(self, name, master=None):
             raise Exception('Widget not defined.')
         return widget
 
-
     def _import_class(self, modulename):
         if modulename.startswith('ttk.'):
             importlib.import_module('pygubu.builder.ttkstdwidgets')
         else:
             importlib.import_module(modulename)
 
-
     def _realize(self, master, element):
         """Builds a widget from xml element using master as parent."""
 
@@ -355,7 +342,6 @@ def _realize(self, master, element):
         else:
             raise Exception('Class "{0}" not mapped'.format(cname))
 
-
     def _check_data(self, data):
         cname = data['class']
         uniqueid = data['id']
@@ -365,7 +351,6 @@ def _check_data(self, data):
             logger.warning('No layout information for: (%s, %s).',
                 cname, uniqueid)
 
-
     def connect_callbacks(self, callbacks_bag):
         """Connect callbacks specified in callbacks_bag with callbacks
         defined in the ui definition.

pygubu/builder/tkstdwidgets.py

@@ -1,5 +1,4 @@
 from __future__ import unicode_literals
-import types
 
 try:
     import tkinter as tk
@@ -8,9 +7,12 @@
 
 from .builderobject import *
 
+
 #
 # tkinter widgets
 #
+
+
 class TKToplevel(BuilderObject):
     class_ = tk.Toplevel
     container = True
@@ -31,7 +33,7 @@ class TKToplevel(BuilderObject):
         'vertically': (False, True),
         'none': (False, False)
         }
-        
+
     def realize(self, parent):
         args = self._get_init_args()
         master = parent.get_child_master()
@@ -40,7 +42,7 @@ def realize(self, parent):
         else:
             self.widget = self.class_(master, **args)
         return self.widget
-        
+
     def _set_property(self, target_widget, pname, value):
         method_props = ('geometry', 'overrideredirect', 'title')
         if pname in method_props:
@@ -63,7 +65,8 @@ def _set_property(self, target_widget, pname, value):
         else:
             super(TKToplevel, self)._set_property(target_widget, pname, value)
 
-register_widget('tk.Toplevel', TKToplevel, 'Toplevel', ('Containers', 'tk', 'ttk'))
+register_widget('tk.Toplevel', TKToplevel,
+                'Toplevel', ('Containers', 'tk', 'ttk'))
 
 
 class TKFrame(BuilderObject):
@@ -99,7 +102,8 @@ class TKLabelFrame(BuilderObject):
         'text', 'takefocus', 'width']
 #TODO: Add helper so the labelwidget can be configured on GUI
 
-register_widget('tk.LabelFrame', TKLabelFrame, 'LabelFrame', ('Containers', 'tk'))
+register_widget('tk.LabelFrame', TKLabelFrame,
+                'LabelFrame', ('Containers', 'tk'))
 
 
 class TKEntry(EntryBaseBO):
@@ -114,7 +118,7 @@ class TKEntry(EntryBaseBO):
         'selectborderwidth', 'selectforeground', 'show', 'state',
         'takefocus', 'textvariable', 'validate', 'validatecommand',
         'invalidcommand', 'width', 'wraplength', 'xscrollcommand',
-        'text', # < text is a custom property
+        'text',  # < text is a custom property
         'validatecommand_args',
         'invalidcommand_args']
     command_properties = ('validatecommand', 'invalidcommand',
@@ -156,7 +160,7 @@ class TKCheckbutton(BuilderObject):
 
 
 class TKListbox(BuilderObject):
-    class_ =  tk.Listbox
+    class_ = tk.Listbox
     container = False
     properties = ['activestyle', 'background', 'borderwidth', 'cursor',
             'disabledforeground', 'exportselection', 'font',
@@ -167,7 +171,8 @@ class TKListbox(BuilderObject):
             'yscrollcommand']
     command_properties = ('xscrollcommand', 'yscrollcommand')
 
-register_widget('tk.Listbox', TKListbox, 'Listbox', ('Control & Display', 'tk'))
+register_widget('tk.Listbox', TKListbox,
+                'Listbox', ('Control & Display', 'tk'))
 
 
 class TKText(BuilderObject):
@@ -182,20 +187,19 @@ class TKText(BuilderObject):
             'selectborderwidth', 'selectforeground', 'spacing1',
             'spacing2', 'spacing3', 'state', 'tabs', 'takefocus',
             'undo', 'width', 'wrap', 'xscrollcommand', 'yscrollcommand',
-            'text'] #<- text is a custom property.
+            'text']  # <- text is a custom property.
     command_properties = ('xscrollcommand', 'yscrollcommand')
 
     def _set_property(self, target_widget, pname, value):
         if pname == 'text':
             target_widget.insert('0.0', value)
         else:
-            super(TKText, self)._set_property(target_widget,pname, value)
+            super(TKText, self)._set_property(target_widget, pname, value)
 
 
 register_widget('tk.Text', TKText, 'Text', ('Control & Display', 'tk', 'ttk'))
 
 
-
 class TKPanedWindow(PanedWindow):
     class_ = tk.PanedWindow
     allowed_children = ('tk.PanedWindow.Pane',)
@@ -223,7 +227,8 @@ class TKMenubutton(BuilderObject):
     def add_child(self, bobject):
         self.widget.configure(menu=bobject.widget)
 
-register_widget('tk.Menubutton', TKMenubutton, 'Menubutton', ('Control & Display', 'tk',))
+register_widget('tk.Menubutton', TKMenubutton,
+                'Menubutton', ('Control & Display', 'tk',))
 
 
 class TKMessage(BuilderObject):
@@ -309,7 +314,8 @@ def configure(self):
                 self.properties['to'] = str(to)
         super(TKSpinbox, self).configure()
 
-register_widget('tk.Spinbox', TKSpinbox, 'Spinbox', ('Control & Display', 'tk'))
+register_widget('tk.Spinbox', TKSpinbox,
+                'Spinbox', ('Control & Display', 'tk'))
 
 
 class TKMenu(BuilderObject):
@@ -362,7 +368,7 @@ class TKMenuitem(BuilderObject):
         'background', 'bitmap', 'columnbreak', 'command', 'compound',
         'font', 'foreground', 'hidemargin', 'image', 'label', 'state',
         'underline',
-        'command_id_arg', #<< custom property !!
+        'command_id_arg',  # << custom property !!
         ]
     command_properties = ('command',)
     allow_bindings = False
@@ -391,7 +397,6 @@ def configure(self):
     def layout(self):
         pass
 
-
     def _create_callback(self, cpname, callback):
         command = callback
         include_id = self.properties.get('command_id_arg', 'False')
@@ -425,7 +430,6 @@ def realize(self, parent):
         master.add(tk.CASCADE, **item_properties)
         return self.widget
 
-
     def configure(self):
         pass
 
@@ -471,7 +475,7 @@ class TKMenuitemSeparator(TKMenuitem):
     command_properties = tuple()
 
 register_widget('tk.Menuitem.Separator', TKMenuitemSeparator,
-        'Menuitem.Separator', ('Pygubu Helpers','tk', 'ttk'))
+                'Menuitem.Separator', ('Pygubu Helpers', 'tk', 'ttk'))
 
 
 class TKPanedWindowPane(PanedWindowPane):