Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protractor E2E tests #32

Open
evilaliv3 opened this issue Dec 19, 2015 · 2 comments
Open

Add protractor E2E tests #32

evilaliv3 opened this issue Dec 19, 2015 · 2 comments

Comments

@evilaliv3
Copy link

It would be valuable that being a library written for angular, unit tests would be rewritten using protractor.

In addition by means of grunt-protractor-runner it would be valuable to interconnect unit tests to saucelabs in order to automatize browser testing; saucelabs infact offer free accounts for opensource projects like angular-shims-placeholder

I'm writing this while integrating the library in GlobaLeaks globaleaks/globaleaks-whistleblowing-software#1533, that has a complete unit testing in place like the one i'm describing and where the library appear to not work properly.

From what i'm testing manually it works great but it seems to cause protractor detecting angularjs startup and this may lie some bugs: https://api.travis-ci.org/jobs/97890200/log.txt?deansi=true

@cvn
Copy link
Owner

cvn commented Dec 21, 2015

Hi @evilaliv3,

I followed some of your links and I'm not sure why the protractor tests are failing. I don't have much experience with protractor.

As a workaround, you can try disabling the shim as part of the test pre-run. Do this by overriding the hasPlaceholder method of the placeholderSniffer service to always return true. Something like this:

myApp.run(function (placeholderSniffer) {
    placeholderSniffer.hasPlaceholder = function () { return true; }
});

And as for you request to add protractor tests, there are no plans to do this. I would be glad to offer assistance if you or anyone else wants to tackle it.

@evilaliv3
Copy link
Author

thanks for the suggestion @cvn! really appreciated.

@cvn cvn changed the title unit tests should be rewritten using protractor Add protractor E2E tests Dec 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants