Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra options to task left click menu #552

Closed
ColemanTom opened this issue Jan 25, 2024 · 5 comments
Closed

Add extra options to task left click menu #552

ColemanTom opened this issue Jan 25, 2024 · 5 comments

Comments

@ColemanTom
Copy link

Problem

Problem is too strong a word. I'm finding, when I have a task expanded, showing the numbered tasks, I bring up the numbered item if I want to do something like Kill the task.

image

Proposed Solution

Add some extra options so they are in both the top level task menu and the individual task menu, where it makes sense. For example, Kill and Poll. Logs already appears in both menu's so this would (I imagine) be a small extension?

@hjoliver
Copy link
Member

hjoliver commented Jan 25, 2024

FYI, the "numbered tasks" are "jobs". As in, a task can submit multiple jobs.

I presume your yellow highlighter has changed running job 5 (blue) to green (which is supposed to represent a succeeded job).

To explain the status quo, when you want to poll or kill a job, you really target a specific task instance (<cycle>/<name>) and the scheduler does it if the task currently has an active job.

That said, I think it's a reasonable suggestion to add poll, and kill to the menu for running jobs, but note that it would only affect the menu for the latest job, and only while it is still running. And other than "view logs", there aren't any other commands that target specific jobs, running or finished.

@ColemanTom
Copy link
Author

Sorry about the terminology and my lazyness not changing from highlight to a pen to circle it like I had originally thought to do. Yes, it was a running job.

And yes, I only thought for the latest active job as you describe. Thanks for clarifying what I meant.

@oliver-sanders
Copy link
Member

Hi, I'm not sure what commands you're expecting to see in which menu.

  • There are some commands which are applicable to tasks but not jobs (e.g. set-outputs). These will not be added to the job menu.
  • There are some tasks commands which may be applicable to jobs but don't appear in the job menu at present for technical reasons.

@oliver-sanders oliver-sanders added this to the pending milestone Jan 26, 2024
@oliver-sanders oliver-sanders added the question Flag this as a question for the next Cylc project meeting. label Jan 26, 2024
@hjoliver
Copy link
Member

Hi, I'm not sure what commands you're expecting to see in which menu.

See my comment above - I said it could only be poll and kill, and only for the latest job and only while it active - and @ColemanTom agreed.

@oliver-sanders
Copy link
Member

oliver-sanders commented Jan 30, 2024

Right. Currently we don't have the ability to poll or kill a specific job as these commands are issued against the task.

When this cylc-flow issue is solved, the poll and kill mutations will automatically show up in the job menu in the GUI (the command lists are auto generated): cylc/cylc-flow#5950

Closing this as transferred to cylc/cylc-flow#5950

@oliver-sanders oliver-sanders removed this from the pending milestone Jan 30, 2024
@oliver-sanders oliver-sanders removed the question Flag this as a question for the next Cylc project meeting. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants