add support for the get_transform analog to set_transform
#264
Conversation
This reverts the formatting changes that were accidentally included with commit 0c21a73.
ziw-liu
added
enhancement
|
Re: CI failure: please refer to the contributing guide. |
|
passed the precommit checks 👍 |
Edit: I remembered it wrong |
Isn't it as simple as returning the |
You're right! I mistakenly thought that |
iohub/ngff/nodes.py
Outdated
| ) | ||
| scale = [s1 * s2 for s1, s2 in zip(scale, trans.scale)] | ||
| return scale | ||
| return self.get_effective_scale("*").scale |
There was a problem hiding this comment.
This used to be the scale of the highest resolution, so it should be the first array instead of "*".
There was a problem hiding this comment.
I think this is why tests are failing for 6fc5ad6.
…olution image metadata
…ve scale and translation transforms
…d of TransformationMeta
|
Separated into 2 unit tests, return plain list of floats instead of |
| arr_name=short_alpha_numeric, | ||
| ) | ||
| def test_get_effective_scale_image(transforms, ch_shape_dtype, arr_name): | ||
| """Test `iohub.ngff.Position.set_transform()`""" |
There was a problem hiding this comment.
| """Test `iohub.ngff.Position.set_transform()`""" | |
| """Test `iohub.ngff.Position.get_effective_scale()`""" |
| arr_name=short_alpha_numeric, | ||
| ) | ||
| def test_get_effective_translation_image(transforms, ch_shape_dtype, arr_name): | ||
| """Test `iohub.ngff.Position.set_transform()`""" |
There was a problem hiding this comment.
| """Test `iohub.ngff.Position.set_transform()`""" | |
| """Test `iohub.ngff.Position.get_effective_translation()`""" |
given a set of scale and translation transforms, defined on both the group and individual individual images, each image will have a final scale and translation. These can now be conveniently retrieved with a little helper function that fetches all appropriate translations and applies them consecutively.
small test added to cover changes.