Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"pass a second argument to layout" is no longer accurate #316

Open
Qix- opened this issue Jun 12, 2021 · 0 comments
Open

"pass a second argument to layout" is no longer accurate #316

Qix- opened this issue Jun 12, 2021 · 0 comments

Comments

@Qix-
Copy link

Qix- commented Jun 12, 2021

Forgive me if I'm missing something, but from the wiki page:

The layout can be configured by either setting the properties in the table below on the appropriate objects in the graph or by passing a second arg to layout with these properties set. The latter takes precedence.

However, when I couldn't get any of it to actually work, I checked the source and found that they're more or less completely ignored:

dagre/lib/layout.js

Lines 20 to 28 in 933822b

function layout(g, opts) {
var time = opts && opts.debugTiming ? util.time : util.notime;
time("layout", function() {
var layoutGraph =
time(" buildLayoutGraph", function() { return buildLayoutGraph(g); });
time(" runLayout", function() { runLayout(layoutGraph, time); });
time(" updateInputGraph", function() { updateInputGraph(g, layoutGraph); });
});
}

Am I missing something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant