Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kitty tabs going transparent. #783

Open
Lalit64 opened this issue Jan 20, 2025 · 8 comments
Open

Kitty tabs going transparent. #783

Lalit64 opened this issue Jan 20, 2025 · 8 comments
Labels
bug Something isn't working properly

Comments

@Lalit64
Copy link
Contributor

Lalit64 commented Jan 20, 2025

Kitty tabs (not tab bar) are going transparent and look ugly.

Should look like
Image

But looks like
Image

As you can see the seperator in the second image is opaque and the tabs are supposed to be the same color but, the tab bar should be transparent.

Image

Basically the area in between the red lines should be transparent and the area outside the red lines should be opaque.
@Lalit64
Copy link
Contributor Author

Lalit64 commented Jan 20, 2025

For reference the catppuccin theme from catppuccin/kitty

Image

@Lalit64 Lalit64 mentioned this issue Jan 20, 2025
Merged
@trueNAHO
Copy link
Collaborator

Maybe both items are set to the same color. What does the generated configuration file look like?

Note that we are mostly delegating the Kitty theming to another repository:

stylix/flake.nix

Lines 82 to 93 in e594886

tinted-kitty = {
flake = false;
# Lock the tinted-kitty input to prevent upstream breaking changes.
#
# Considering that Stylix eventually re-implements this input's
# functionality [1], it might be easiest to lock this input to avoid
# wasted maintenance effort.
#
# [1]: https://github.com/danth/stylix/issues/534
url = "github:tinted-theming/tinted-kitty/eb39e141db14baef052893285df9f266df041ff8";
};

@trueNAHO trueNAHO added the bug Something isn't working properly label Jan 23, 2025
@Lalit64
Copy link
Contributor Author

Lalit64 commented Jan 24, 2025 •
edited
Loading

@trueNAHO

# Base16 Catppuccin Mocha - kitty color config
# Scheme by https://github.com/catppuccin/catppuccin
background #1e1e2e
foreground #cdd6f4
selection_background #cdd6f4
selection_foreground #1e1e2e
url_color #585b70
cursor #cdd6f4
active_border_color #45475a
inactive_border_color #181825
active_tab_background #1e1e2e
active_tab_foreground #cdd6f4
inactive_tab_background #181825
inactive_tab_foreground #585b70
tab_bar_background #181825
wayland_titlebar_color #1e1e2e
macos_titlebar_color #1e1e2e

# normal
color0 #1e1e2e
color1 #f38ba8
color2 #a6e3a1
color3 #f9e2af
color4 #89b4fa
color5 #cba6f7
color6 #94e2d5
color7 #cdd6f4

# bright
color8 #45475a
color9 #fab387
color10 #181825
color11 #313244
color12 #585b70
color13 #f5e0dc
color14 #f2cdcd
color15 #b4befe

@Lalit64
Copy link
Contributor Author

Lalit64 commented Jan 27, 2025

for reference the mocha.conf from https://github.com/catppuccin/kitty is

# vim:ft=kitty

## name:     Catppuccin Kitty Mocha
## author:   Catppuccin Org
## license:  MIT
## upstream: https://github.com/catppuccin/kitty/blob/main/themes/mocha.conf
## blurb:    Soothing pastel theme for the high-spirited!



# The basic colors
foreground              #cdd6f4
background              #1e1e2e
selection_foreground    #1e1e2e
selection_background    #f5e0dc

# Cursor colors
cursor                  #f5e0dc
cursor_text_color       #1e1e2e

# URL underline color when hovering with mouse
url_color               #f5e0dc

# Kitty window border colors
active_border_color     #b4befe
inactive_border_color   #6c7086
bell_border_color       #f9e2af

# OS Window titlebar colors
wayland_titlebar_color system
macos_titlebar_color system

# Tab bar colors
active_tab_foreground   #11111b
active_tab_background   #cba6f7
inactive_tab_foreground #cdd6f4
inactive_tab_background #181825
tab_bar_background      #11111b

# Colors for marks (marked text in the terminal)
mark1_foreground #1e1e2e
mark1_background #b4befe
mark2_foreground #1e1e2e
mark2_background #cba6f7
mark3_foreground #1e1e2e
mark3_background #74c7ec

# The 16 terminal colors

# black
color0 #45475a
color8 #585b70

# red
color1 #f38ba8
color9 #f38ba8

# green
color2  #a6e3a1
color10 #a6e3a1

# yellow
color3  #f9e2af
color11 #f9e2af

# blue
color4  #89b4fa
color12 #89b4fa

# magenta
color5  #f5c2e7
color13 #f5c2e7

# cyan
color6  #94e2d5
color14 #94e2d5

# white
color7  #bac2de
color15 #a6adc8

@trueNAHO
Copy link
Collaborator 

# Base16 Catppuccin Mocha - kitty color config
# Scheme by https://github.com/catppuccin/catppuccin
background #1e1e2e
foreground #cdd6f4
selection_background #cdd6f4
selection_foreground #1e1e2e
url_color #585b70
cursor #cdd6f4
active_border_color #45475a
inactive_border_color #181825
active_tab_background #1e1e2e
active_tab_foreground #cdd6f4
inactive_tab_background #181825
inactive_tab_foreground #585b70
tab_bar_background #181825
wayland_titlebar_color #1e1e2e
macos_titlebar_color #1e1e2e

# normal
color0 #1e1e2e
color1 #f38ba8
color2 #a6e3a1
color3 #f9e2af
color4 #89b4fa
color5 #cba6f7
color6 #94e2d5
color7 #cdd6f4

# bright
color8 #45475a
color9 #fab387
color10 #181825
color11 #313244
color12 #585b70
color13 #f5e0dc
color14 #f2cdcd
color15 #b4befe

#181825 and #1e1e2e look almost identical, which might be causing your problem.

Since we are intentionally locking our tinted-kitty input, it is unlikely this will be resolved without some effort. Otherwise, we could remove the tinted-kitty input and implement it ourselves, essentially reverting commit ad560b2 ("Improve kitty module (#42)").

@Lalit64
Copy link
Contributor Author

Lalit64 commented Jan 28, 2025 •
edited
Loading

@trueNAHO would filing an issue on the https://github.com/tinted-theming/tinted-terminal repository work?

edit: I think that this might be an issue for the majority if they have the same specific config. Basically I think that anyone would like the active tab to have a solid background and the inactive tab and tab bar background to be equal to the terminal opacity

@trueNAHO
Copy link
Collaborator

would filing an issue on the https://github.com/tinted-theming/tinted-terminal repository work?

This would not resolve the Stylix issue, since we are not using this dependency:

Consider migrating to the new github:tinted-theming/tinted-terminal repository, which archives several repositories we depend on.

This issue is a very low priority task and is mostly only opened for future reference.

-- #779

Instead, the kitty theme:

stylix/modules/kitty/hm.nix

Lines 5 to 8 in e594886

theme = config.lib.stylix.colors {
templateRepo = config.lib.stylix.templates.tinted-kitty;
target = if cfg.variant256Colors then "default-256" else "default";
};

uses the locked tinted-kitty input:

stylix/flake.nix

Lines 82 to 93 in e594886

tinted-kitty = {
flake = false;
# Lock the tinted-kitty input to prevent upstream breaking changes.
#
# Considering that Stylix eventually re-implements this input's
# functionality [1], it might be easiest to lock this input to avoid
# wasted maintenance effort.
#
# [1]: https://github.com/danth/stylix/issues/534
url = "github:tinted-theming/tinted-kitty/eb39e141db14baef052893285df9f266df041ff8";
};

Resolving this probably requires:

Since we are intentionally locking our tinted-kitty input, it is unlikely this will be resolved without some effort. Otherwise, we could remove the tinted-kitty input and implement it ourselves, essentially reverting commit ad560b2 ("Improve kitty module (#42)").

-- #783 (comment)

edit: I think that this might be an issue for the majority if they have the same specific config. Basically I think that anyone would like the active tab to have a solid background and the inactive tab and tab bar background to be equal to the terminal opacity

True. But this will have no effect on Stylix for the time being.

Sorry for the inconvenience.

@Lalit64
Copy link
Contributor Author

Lalit64 commented Jan 31, 2025 •
edited
Loading

Ok, I think it might be best to leave this open I will file an issue on the tinted-kitty github.

Edit: I didn't realise that tinted-kitty was archived 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working properly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lalit64 @trueNAHO