Skip to content

Commit 71e06af

Browse files
committed
drivers/regulator/virtual: avoid world-writable sysfs files.
In line with practice for module parameters, we're adding a build-time check that sysfs files aren't world-writable. Cc: Mark Brown <[email protected]> Signed-off-by: Rusty Russell <[email protected]>
1 parent 332e2b4 commit 71e06af

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/regulator/virtual.c

+5-5
Original file line numberDiff line numberDiff line change
@@ -266,11 +266,11 @@ static ssize_t set_mode(struct device *dev, struct device_attribute *attr,
266266
return count;
267267
}
268268

269-
static DEVICE_ATTR(min_microvolts, 0666, show_min_uV, set_min_uV);
270-
static DEVICE_ATTR(max_microvolts, 0666, show_max_uV, set_max_uV);
271-
static DEVICE_ATTR(min_microamps, 0666, show_min_uA, set_min_uA);
272-
static DEVICE_ATTR(max_microamps, 0666, show_max_uA, set_max_uA);
273-
static DEVICE_ATTR(mode, 0666, show_mode, set_mode);
269+
static DEVICE_ATTR(min_microvolts, 0664, show_min_uV, set_min_uV);
270+
static DEVICE_ATTR(max_microvolts, 0664, show_max_uV, set_max_uV);
271+
static DEVICE_ATTR(min_microamps, 0664, show_min_uA, set_min_uA);
272+
static DEVICE_ATTR(max_microamps, 0664, show_max_uA, set_max_uA);
273+
static DEVICE_ATTR(mode, 0664, show_mode, set_mode);
274274

275275
static struct attribute *regulator_virtual_attributes[] = {
276276
&dev_attr_min_microvolts.attr,

0 commit comments

Comments
 (0)