Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding simolus3 as a committer to this repo #3773

Open
devoncarew opened this issue Nov 21, 2024 · 3 comments
Open

adding simolus3 as a committer to this repo #3773

devoncarew opened this issue Nov 21, 2024 · 3 comments

Comments

@devoncarew
Copy link
Member

Hi @simolus3 - it looks like you've contributed many quality PRs to this repo (#3771, ...). Thanks! Are you interested in being made a committer here? You'd be able to land your own PRs (after review) and would not have to have someone else approve workflows.

You would need to agree to uphold our standard contributor process (when creating PRs or when reviewing others). That's not fully documented; some of it is mentioned here: https://github.com/dart-lang/build/blob/master/CONTRIBUTING.md, but mostly PRs need to maintain our quality bar including having tests, changelog entries, ...

Adding @jakemac53 for thoughts as well.

@jakemac53
Copy link
Contributor

I am supportive of this 👍

@simolus3
Copy link
Contributor

Thanks! I don't think this would change how I contribute here that much since the review process stays the same, but not having to wait for my workflows to get approved would sure be helpful :)

@devoncarew
Copy link
Member Author

Thanks! I don't think this would change how I contribute here that much since the review process stays the same, but not having to wait for my workflows to get approved would sure be helpful :)

Fore sure! Just for clarity - your PRs have been good; once you're a committer here though you'd be able to review PRs as well.

Poking around, our best docs for PR reviews are here and here.

I'll update some permissions and ping here when that's complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants