You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @simolus3 - it looks like you've contributed many quality PRs to this repo (#3771, ...). Thanks! Are you interested in being made a committer here? You'd be able to land your own PRs (after review) and would not have to have someone else approve workflows.
You would need to agree to uphold our standard contributor process (when creating PRs or when reviewing others). That's not fully documented; some of it is mentioned here: https://github.com/dart-lang/build/blob/master/CONTRIBUTING.md, but mostly PRs need to maintain our quality bar including having tests, changelog entries, ...
Thanks! I don't think this would change how I contribute here that much since the review process stays the same, but not having to wait for my workflows to get approved would sure be helpful :)
Thanks! I don't think this would change how I contribute here that much since the review process stays the same, but not having to wait for my workflows to get approved would sure be helpful :)
Fore sure! Just for clarity - your PRs have been good; once you're a committer here though you'd be able to review PRs as well.
Poking around, our best docs for PR reviews are here and here.
I'll update some permissions and ping here when that's complete.
Hi @simolus3 - it looks like you've contributed many quality PRs to this repo (#3771, ...). Thanks! Are you interested in being made a committer here? You'd be able to land your own PRs (after review) and would not have to have someone else approve workflows.
You would need to agree to uphold our standard contributor process (when creating PRs or when reviewing others). That's not fully documented; some of it is mentioned here: https://github.com/dart-lang/build/blob/master/CONTRIBUTING.md, but mostly PRs need to maintain our quality bar including having tests, changelog entries, ...
Adding @jakemac53 for thoughts as well.
The text was updated successfully, but these errors were encountered: