Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SDK archive page #1656

Closed
3 of 4 tasks
kwalrath opened this issue Jun 3, 2019 · 7 comments
Closed
3 of 4 tasks

Improve SDK archive page #1656

kwalrath opened this issue Jun 3, 2019 · 7 comments
Assignees
Labels
e2-days Can complete in < 5 days of normal, not dedicated, work p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@kwalrath
Copy link
Contributor

kwalrath commented Jun 3, 2019

This is an umbrella issue for requests for https://dart.dev/tools/sdk/archive:

/cc @johnpryan @domesticmouse

@kwalrath kwalrath added p1-high Major but not urgent concern: Resolve in months. Update each month. e2-days Can complete in < 5 days of normal, not dedicated, work labels Jun 3, 2019
@kwalrath kwalrath changed the title Improve archive page Improve SDK archive page Jun 3, 2019
@kwalrath
Copy link
Contributor Author

kwalrath commented Jun 3, 2019

I added a couple of other bugs (very old) to the list.

@johnpryan
Copy link
Contributor

Quick update: it looks like we will be able to use the sdk_builds package (#75) but either way there needs to be a fair number of network calls in order to display the correct version for pre-1.11.0-dev.0.0 since those are SVN revisions.

I'm going to start with a PR that updates to using sdk_builds (#75) and uses the sdk_buildspackage (dart-lang/site-shared#97) and leave analytics and performance issues for the next iteration

@johnpryan
Copy link
Contributor

johnpryan commented Jun 4, 2019

FWIW we do have the option of greatly improving the performance if we manually mapped the SVN revisions to version strings:

using the getVersionPaths() from package:sdk_builds is a single HTTP call but results in SVN versions mixed with the others:

Screen Shot 2019-06-04 at 4 52 50 PM

package:sdk_builds could just provide a hard-coded Map from the SVN revision to the Dart version since that information won't change

@johnpryan
Copy link
Contributor

I have a working prototype here that uses a dart 2 compatible branch of sdk_builds (kevmoo/sdk_builds.dart#1).

I'm currently running into an issue with the googleapis Storage class provided by sdk_builds and filed an issue here (google/googleapis.dart#73)

@kwalrath
Copy link
Contributor Author

kwalrath commented Jun 5, 2019

Is the prototype staged anywhere?

@johnpryan
Copy link
Contributor

http://jpryan.me/dart_sdk_archive/

@kwalrath kwalrath added p0-critical Critical and urgent concern: breaks builds, impacts team velocity. Resolve in weeks. Update weekly. p2-medium Necessary but not urgent concern. Resolve when possible. and removed p0-critical Critical and urgent concern: breaks builds, impacts team velocity. Resolve in weeks. Update weekly. p1-high Major but not urgent concern: Resolve in months. Update each month. labels Aug 9, 2019
@johnpryan
Copy link
Contributor

Since the only remaining issue is #89, I'm going to close this so we can just track that specific issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2-days Can complete in < 5 days of normal, not dedicated, work p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Development

No branches or pull requests

2 participants