Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TestAccBundleDeployUcSchema test #1997

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

andrewnester
Copy link
Contributor

@andrewnester andrewnester commented Dec 11, 2024

Changes

It was failing because when schema.yml was removed, catalog: main option left set in the base pipeline definition in databricks.yml which lead to incorrect config (empty target schema)
#1413

Backend behaviour changed and DLT pipelines stopped to accept empty targets leading to the error which was ignored before.

Tests

--- PASS: TestAccBundleDeployUcSchema (41.75s)
PASS
coverage: 33.3% of statements in ./...
ok      github.com/databricks/cli/internal/bundle       42.210s coverage: 33.3% of statements in ./...

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 1997
  • Commit SHA: 9eda1d3ececb3b5149bb97117ac89f0efc0b7733

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12276830250

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include a PR link in the summary to where this was changed?

Was the failure triggered by a commit or by something changing on the backend?

@andrewnester
Copy link
Contributor Author

Was the failure triggered by a commit or by something changing on the backend?

Yes, this is a backend change, no changes from CLI side were done

@andrewnester andrewnester added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit aa0b608 Dec 11, 2024
11 checks passed
@andrewnester andrewnester deleted the fix/uc-schema-test branch December 11, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants