Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Modules don't work with wildcards #76

Open
JessicaSachs opened this issue Sep 10, 2019 · 2 comments
Open

Nested Modules don't work with wildcards #76

JessicaSachs opened this issue Sep 10, 2019 · 2 comments

Comments

@JessicaSachs
Copy link

JessicaSachs commented Sep 10, 2019

Hey Dave, I don't believe that wildcard notation works with nested modules. When the nested modules are flattened (backslashes removed), they work again.

https://codesandbox.io/s/vuex-pathify-main-demo-b964j?fontsize=14

@davestewart
Copy link
Owner

OK, I had a quick look.

I think the problem is that I'm not properly supporting nested modules:

I'll update the ticket title and schedule some time to fix!

@davestewart davestewart changed the title Nested Modules don't work with wildcards Nested Modules don't work Sep 10, 2019
@davestewart
Copy link
Owner

davestewart commented Sep 11, 2019

OK... looks like nested modules and wildcards are fine...

...at least:

  • without registerModule():
  • in state and getters
  • using get()

I REALLY have to get these automated tests done.

That is my next to-do item, thanks to the excellent initial work done by @axwalker.

Maybe I will get onto that this weekend.

@davestewart davestewart changed the title Nested Modules don't work Nested Modules don't work with wildcards Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants