Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Variable upgrade color is wrong in Smith View #173

Closed
Skrelpoid opened this issue Jan 3, 2019 · 5 comments
Closed

Dynamic Variable upgrade color is wrong in Smith View #173

Skrelpoid opened this issue Jan 3, 2019 · 5 comments

Comments

@Skrelpoid
Copy link

Like the title says, the color of a value that is upgraded is wrong in the Smith View (where you go after you click on Smith on a camp fire)
The color is correct in the card inspect view:
screenshot_11
but not in the smith view:
screenshot_12

@kiooeht
Copy link
Collaborator

kiooeht commented Jan 5, 2019

So you know, once it's released, you will have to override a new method on DynamicVariable called setIsModified in order for the smith view to work for your dynamic variables.

@Skrelpoid
Copy link
Author

So in the setIsModified i have to set a value so isModified returns true for the card, correct?

@kiooeht
Copy link
Collaborator

kiooeht commented Jan 5, 2019

Correct.

@kiooeht kiooeht closed this as completed in 6bc8b86 Jan 8, 2019
@kiooeht
Copy link
Collaborator

kiooeht commented Jan 8, 2019

I had to revert the build with this on Steam because this change is causing crashes.

@kiooeht kiooeht reopened this Jan 8, 2019
@kiooeht
Copy link
Collaborator

kiooeht commented Jan 8, 2019

It's back in v5.7.1 on the Workshop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants