Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Disable console case sensitivity #9

Open
gskleres opened this issue Mar 5, 2018 · 3 comments
Open

Request: Disable console case sensitivity #9

gskleres opened this issue Mar 5, 2018 · 3 comments
Labels
confirmed This bug has been confirmed to exist enhancement New feature or request known-issue Issue is known about and is not likely to be fixed soon

Comments

@gskleres
Copy link

gskleres commented Mar 5, 2018

Hey would it be possible to disable case sensitivity in BaseMod's console? So all card strings could be pushed to lower case for comparison? Have not dug through the code so I don't know if that would even be possible, or if it would require a lot of extra code. Perhaps make a hash map of the cards when it loads with their lower case values?

The goal is so that the following 2 lines produce the same result:

deck add BloodForBlood
deck add bloodforblood

@daviscook477 daviscook477 added the enhancement New feature or request label Mar 5, 2018
@daviscook477
Copy link
Owner

This isn't as easy as it sounds since the in-game IDs are hardcoded in uppercamelcase. I might look into it eventually.

@gskleres
Copy link
Author

gskleres commented Mar 5, 2018

Is it possible to iterate through the cards that exist? If so, perhaps you could iterate through each card and create a hash map for the dev console where the key is the toLowerCase() equivalent of the ID (however that works in Java) and the value is the actual properly camel cased ID? And then, if that's possible, you could still allow regular camel casing in the console by simply checking first for the ID and then if it fails checking the hash map for a lower case key?

Caveat: I haven't even opened the code for this project once, so please feel free to ignore me. :)

@daviscook477
Copy link
Owner

Yeah that would probably work but I'm not likely to get around to this any time soon.

@daviscook477 daviscook477 added the known-issue Issue is known about and is not likely to be fixed soon label Mar 7, 2018
@daviscook477 daviscook477 added the confirmed This bug has been confirmed to exist label Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed This bug has been confirmed to exist enhancement New feature or request known-issue Issue is known about and is not likely to be fixed soon
Projects
None yet
Development

No branches or pull requests

2 participants