New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About cam2prior_t in compute_cam2prior() #50

Open

nnop opened this issue Jul 9, 2024 · 0 comments

nnop commented Jul 9, 2024 •

edited

Loading

cam2prior_t is computed as -trans in the code:

humor/humor/fitting/fitting_utils.py

Lines 181 to 185 in fc6ef84

    
           prior_R = torch.stack([right_axis, fwd_axis, up_axis], dim=2) 
        
           cam2prior_R = prior_R.transpose(2, 1) 
        
           # translation takes translation to origin plus offset to the floor 
        
           cam2prior_t = -trans

Shouldn't it be -cam2prior_R @ trans?

I logged the value of trans and cam2prior_t.

trans: [0.0655, 0.2377, 4.0186]
cam2prior_t: [-0.0655, -0.2377, -4.0186]

As the z axis of the prior frame is up axis. cam2prior_t makes the camera below the body.
Was that right?

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment