Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HHVM to Travis #107

Closed
dbudwin opened this issue Oct 3, 2017 · 4 comments
Closed

Add support for HHVM to Travis #107

dbudwin opened this issue Oct 3, 2017 · 4 comments

Comments

@dbudwin
Copy link
Owner

dbudwin commented Oct 3, 2017

The .travis.yml will need to be modified to include HHVM and any breaking changes will need to be resolved as well. If for whatever reason it's not possible to support HHVM with a reasonable amount of effort, the reason why should be detailed for future reference.

@padarom
Copy link

padarom commented Oct 3, 2017

https://laravel.com/docs/5.3/upgrade#upgrade-5.3.0

Laravel lost HHVM support in version 5.3 due to incompatible language features with PHP5.6+

@dbudwin
Copy link
Owner Author

dbudwin commented Oct 3, 2017

Gothca, I knew there was a reason I removed HHVM support a while back, but couldn't recall the reasoning. Now that it's documented that should help keep track of the issue.

@theofidry
Copy link

I would recommend against it: Laravel dropped support for HHVM. Also HHVM offers very limited benefits over PHP7 if you are not using Hack, has some PHP7 incompatibility and given that Hack is never going to be PHP7 compatible, this is unlikely to go better.

@dbudwin
Copy link
Owner Author

dbudwin commented Oct 3, 2017

Sounds good. I'm going to go ahead and close out this issue then.

@dbudwin dbudwin closed this as completed Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants