Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create unit tests for models #17

Closed
dbudwin opened this issue Oct 13, 2016 · 6 comments
Closed

Create unit tests for models #17

dbudwin opened this issue Oct 13, 2016 · 6 comments
Labels
Hacktoberfest 🆘 Help Wanted

Comments

@dbudwin
Copy link
Owner

dbudwin commented Oct 13, 2016

It'll be great to have unit tests set up for the models in this project to ensure they persist and retrieve data to the MySQL database correctly. I've already set up a testing framework per issue #9 which supports testing databases. If any other additional utilities are needed (like a mocking framework) I'm open to adding them too in their own individual PR. I recently included the MySQL schema in PR #13 for anyone that may need it.

I think doing a PR per model class is appropriate and I'll gladly support adding the Hacktoberfest label to any of them!
@dbudwin dbudwin mentioned this issue Oct 13, 2016
Closed
@mccullagh
Copy link
Contributor

I can help you with that. I should have a PR tomorrow.

@dbudwin
Copy link
Owner Author

dbudwin commented Oct 15, 2016

Awesome @mccullagh! I appreciate the help. Let me know if you have any questions or need help with anything.

@mccullagh mccullagh mentioned this issue Oct 15, 2016
Merged
@dbudwin
Copy link
Owner Author

dbudwin commented Oct 28, 2016

PR #29 is currently beginning to address this.

@dbudwin
Copy link
Owner Author

dbudwin commented Nov 2, 2016

PR #40 #43 also address this.

@dbudwin
Copy link
Owner Author

dbudwin commented Nov 6, 2016

Waiting on this issue to be resolved before I create a model test for UserDevicesViewModel: https://github.com/dumblob/mysql2sqlite/issues/14

@dbudwin
Copy link
Owner Author

dbudwin commented Feb 22, 2017

Completed in #51

@dbudwin dbudwin closed this as completed Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest 🆘 Help Wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mccullagh @dbudwin