Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unit tests for controllers #18

Closed
dbudwin opened this issue Oct 13, 2016 · 1 comment
Closed

Create unit tests for controllers #18

dbudwin opened this issue Oct 13, 2016 · 1 comment

Comments

@dbudwin
Copy link
Owner

dbudwin commented Oct 13, 2016

Having unit tests for controllers is critical to making sure the web application routes and handles user web requests as expected. For example, testing to make sure a user can't delete a device that belongs to someone else. Or testing that if you try to view a protected page and are not logged in, the user is redirected to the log in page. If any other additional utilities are needed (like a mocking framework) I'm open to adding them too in their own individual PR.

I think doing a PR per controller class is appropriate and I'll gladly support adding the Hacktoberfest label to any of them!

@dbudwin
Copy link
Owner Author

dbudwin commented Feb 22, 2017

Completed in #51

@dbudwin dbudwin closed this as completed Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant