Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'id' to 'deviceId' for turnOn and turnOff API methods #81

Closed
dbudwin opened this issue May 23, 2017 · 2 comments
Closed

Change 'id' to 'deviceId' for turnOn and turnOff API methods #81

dbudwin opened this issue May 23, 2017 · 2 comments
Labels
💎 Enhancement

Comments

@dbudwin
Copy link
Owner

dbudwin commented May 23, 2017

Change id to deviceId for turnOn and turnOff API methods. This will make it consistent with the info API method.
@dbudwin
Copy link
Owner Author

dbudwin commented Oct 2, 2017

This also applies to the handleControlRequest method in the API as well.

@dbudwin dbudwin mentioned this issue Oct 2, 2017
Open
@dbudwin
Copy link
Owner Author

dbudwin commented Sep 7, 2018

This was inadvertently resolved in previous pull requests refactoring how the controllers work like #146.

@dbudwin dbudwin closed this as completed Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbudwin