-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signature is changed after submitting transaction #282
Comments
We fully reproduced it. It happens when you send 2 diamond transactions in a row with using last utxo as input and happens on 2nd one. So we sent using bundle transaction by protocol 1st diamond tx
It has id 3JuEU8EdT2LXSxY9vBnEHAszEwaqc5gDNH7ktmJkmgjea29WVPsM1b same as we can see in explorer After we prepared and send 2nd diamond transaction USING node submit tx method
So if you calculate ID of it, should be – *3JuETUCoGUsKT2KmeMGGjjhGs8tRtW9fTqtzVoGCWrS8cjPr72QqWX` Node returned
Screenshot Checking in mempool and OMG. Signature changed??? how? New ID - * 3JuETXQMinRcn5XBskY1ZPmn41vEFexzJLg6cjHcT2mn32jRoBVGRQ* 3JuETXQMinRcn5XBskY1ZPmn41vEFexzJLg6cjHcT2mn32jRoBVGRQ Body hex
You can see SAME body but DIFFERENT signature (not same that was send)
Looking for clarification how it's possible? Why orignal signature of transaction CHANGED by node without prior notice? |
I believe this was incorrect behavior because I expected my original BODY to be used and not modified like this when I sent the transaction. Any chances to get fixed it? If the tx is not OK, it should be rejected but NOT MODIFIED, in my opinion. |
OK, I just wrote a small script and found an issue. Go lang is not my language, so I do not know why it happens, and not so familiar with its libs.
go run script.go And now we can see that signature changed:
|
@donhardman we're looking into this. How did you prepare the signature? Did you use Identity to prepare it or some other mechanism? We need to inspect the code that prepared the signature in order to debug this. There are two ways to fix this:
I believe the first path is far easier. |
Please explain the full process you used to:
We need to be able to trace all of the code from beginning to end in order to help. |
|
I fully agree that the way to fix how the signature is built is the best. So it's about identity service, then. |
@donhardman - are you still experiencing this issue or did the update to identity resolve your concern? If so, may we close this issue? |
Seems like it's okay now. Sorry for late reply! Thank you for fixing it |
We have weird issue.. That signature is changed for submitted transaction. How is it possible?
So we sent transaction
and after we can see that there is no such transaction but we have same body and different signature after
Somehow it happens with diamonds transaction (seems only)
Also it seems like happens not all the time.
What are we missing?
The text was updated successfully, but these errors were encountered: