-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include /cog endpoints in titiler-pgstac by default #106
Comments
IMO, no custom handler should live in eoapi-cdk! That's said, we have three choice:
|
So the default is the Tiler works with any bucket, but we restrict it to only the STAC records, so some control over that buckets is possible? Should default config recommend an Allow list that would apply to the COG endpoint to prevent usage outside of expected buckets, in titiler-pgstac? @hrodmn @jjfrench which solution do you think makes the most sense? |
Thanks for your suggestions, @vincentsarago! If you are open to it my preference would be to add an option in titiler-pgstac for users to enable the basic I think the discussion about security in the MAAP context belongs in https://github.com/NASA-IMPACT/active-maap-sprint/issues/988 so I'll take that discussion over there, but it is already possible to specify the S3 buckets that the titiler-pgstac Lambda has access to using the eoapi-cdk/lib/titiler-pgstac-api/index.ts Line 130 in 7536c55
The default behavior is to allow access to NO buckets but it is possible to provide a wildcard and enable ALL buckets, which is what I have done in the past. For MAAP we specify a single bucket for the I'm not sure that prevents someone from requesting tiles for a dataset at an arbitrary URL, though, so to prevent access to all files on the web we would need to make sure the Lambda didn't have internet access. |
This issue may belong in titiler-pgstac, but one thing that would make the default eoapi-cdk deployment even better would be to include the
/cog
endpoints fromtitiler
. @jjfrench is working on consolidating ourtitiler
deployments over in MAAP and one thing that is preventing us from running everything on a singletitiler-pgstac
deployment is the/cog
endpoints which are available in an oldtitiler
deployment but not in theeoapi
deployment. It can be useful to be able to use the/cog
endpoints to inspect data before it is cataloged in a STAC item. Maybe it would be better described by a set of/external
endpoints to use for data that is not in the STAC yet. I'm not sure but I think there has been a similar discussion in VEDA cc @wildintellect.It would be pretty simple to add to the
handler.py
in this repo or intitiler.pgstac.main.app
. A user could customize eoapi to add these endpoints but it might also make sense to include that set of endpoints by default.The text was updated successfully, but these errors were encountered: