fix: pure/set revise insert delete return types to (Set<T>, Bool), not ?Set<T> #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanasa
approved these changes
Feb 26, 2025
|
No description provided. |
crusso
added a commit
that referenced
this pull request
Feb 26, 2025
* import OrderedSet * initial port of OrderedMap * port OrderedSet * port OrderSet.prop.test * fix Set.toText * fix test * rename pure/OrderedSet to pure/Set * implement compare, forEach, filter * test compare * test forEach/filter * implement and test join/flatten * harmonize Map/Set.equals functions to take a comparison for the key/element type. This will support future optimization even if we don't exploit the ordering just yet (pure/Set.equals does, however). * restore optimization in Set.mo (using imperative Lists) * settle on non-trappring add/remove, insert/delete * rename pure/Set.intersection/difference * revise pure/Set.insert/delete to return (Set<T>, Bool) not ?Set<T> (#177) * revalidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more symmetric with the imperative insert/delete and easier to use when you still want to work with the set even if unchanged.