Fixes oven-sh#9430 (oven-sh#9472)

Co-authored-by: Jarred Sumner <[email protected]>

Author: Jarred-Sumner

src/bun.js/api/bun/process.zig

@@ -543,6 +543,28 @@ pub const Status = union(enum) {
             else => null,
         };
     }
+
+    pub fn format(self: @This(), comptime _: []const u8, _: anytype, writer: anytype) !void {
+        if (self.signalCode()) |signal_code| {
+            if (signal_code.toExitCode()) |code| {
+                try writer.print("code: {d}", .{code});
+                return;
+            }
+        }
+
+        switch (self) {
+            .exited => |exit| {
+                try writer.print("code: {d}", .{exit.code});
+            },
+            .signaled => |signal| {
+                try writer.print("signal: {d}", .{@intFromEnum(signal)});
+            },
+            .err => |err| {
+                try writer.print("{}", .{err});
+            },
+            else => {},
+        }
+    }
 };
 
 pub const PollerPosix = union(enum) {

src/install/install.zig

@@ -8482,6 +8482,7 @@ pub const PackageManager = struct {
                 .package_version = resolution_label,
                 // .install_order = this.tree_iterator.order,
             };
+            debug("Installing {s}@{s}", .{ name, resolution_label });
 
             switch (resolution.tag) {
                 .npm => {
@@ -8742,7 +8743,14 @@ pub const PackageManager = struct {
                                     );
                                 },
                                 .npm => {
-                                    if (comptime Environment.allow_assert) std.debug.assert(!resolution.value.npm.url.isEmpty());
+                                    if (comptime Environment.isDebug) {
+                                        // Very old versions of Bun didn't store the tarball url when it didn't seem necessary
+                                        // This caused bugs. We can't assert on it because they could come from old lockfiles
+                                        if (resolution.value.npm.url.isEmpty()) {
+                                            Output.debugWarn("package {s}@{} missing tarball_url", .{ name, resolution.fmt(buf) });
+                                        }
+                                    }
+
                                     this.manager.enqueuePackageForDownload(
                                         name,
                                         dependency_id,

src/install/lifecycle_script_runner.zig

@@ -12,6 +12,7 @@ const WaiterThread = bun.spawn.WaiterThread;
 const Timer = std.time.Timer;
 
 const Process = bun.spawn.Process;
+const log = Output.scoped(.Script, false);
 pub const LifecycleScriptSubprocess = struct {
     package_name: []const u8,
 
@@ -28,6 +29,8 @@ pub const LifecycleScriptSubprocess = struct {
 
     timer: ?Timer = null,
 
+    has_incremented_alive_count: bool = false,
+
     pub usingnamespace bun.New(@This());
 
     pub const min_milliseconds_to_log = 500;
@@ -84,8 +87,17 @@ pub const LifecycleScriptSubprocess = struct {
     var cwd_z_buf: bun.PathBuffer = undefined;
 
     pub fn spawnNextScript(this: *LifecycleScriptSubprocess, next_script_index: u8) !void {
-        _ = alive_count.fetchAdd(1, .Monotonic);
-        errdefer _ = alive_count.fetchSub(1, .Monotonic);
+        if (!this.has_incremented_alive_count) {
+            this.has_incremented_alive_count = true;
+            _ = alive_count.fetchAdd(1, .Monotonic);
+        }
+
+        errdefer {
+            if (this.has_incremented_alive_count) {
+                this.has_incremented_alive_count = false;
+                _ = alive_count.fetchSub(1, .Monotonic);
+            }
+        }
 
         const manager = this.manager;
         const original_script = this.scripts.items[next_script_index].?;
@@ -119,6 +131,8 @@ pub const LifecycleScriptSubprocess = struct {
 
         const combined_script: [:0]u8 = copy_script.items[0 .. copy_script.items.len - 1 :0];
 
+        log("{s} - {s} $ {s}", .{ this.package_name, this.scriptName(), combined_script });
+
         var argv = [_]?[*:0]const u8{
             shell_bin,
             if (Environment.isWindows) "/c" else "-c",
@@ -225,6 +239,13 @@ pub const LifecycleScriptSubprocess = struct {
     }
 
     fn handleExit(this: *LifecycleScriptSubprocess, status: bun.spawn.Status) void {
+        log("{s} - {s} finished {}", .{ this.package_name, this.scriptName(), status });
+
+        if (this.has_incremented_alive_count) {
+            this.has_incremented_alive_count = false;
+            _ = alive_count.fetchSub(1, .Monotonic);
+        }
+
         switch (status) {
             .exited => |exit| {
                 const maybe_duration = if (this.timer) |*t| t.read() else null;

src/install/lockfile.zig

@@ -3153,6 +3153,12 @@ pub const Package = extern struct {
             dependencies_list.items = dependencies_list.items.ptr[0..new_length];
             resolutions_list.items = resolutions_list.items.ptr[0..new_length];
 
+            if (comptime Environment.isDebug) {
+                if (package.resolution.value.npm.url.isEmpty()) {
+                    Output.panic("tarball_url is empty for package {s}@{}", .{ manifest.name(), version });
+                }
+            }
+
             return package;
         }
     }