From 73a8ad2e281ddd97d84abcc038a2ce42cef1ab3c Mon Sep 17 00:00:00 2001 From: Damian Gryski Date: Mon, 10 Aug 2015 13:50:44 +0200 Subject: [PATCH] s/FIXME/TODO/ to match preferred Go style --- hokud/main.go | 2 +- hokud/topk.go | 2 +- sketch/sketch.go | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hokud/main.go b/hokud/main.go index 098d850..7d8c94a 100644 --- a/hokud/main.go +++ b/hokud/main.go @@ -171,7 +171,7 @@ func topkHandler(w http.ResponseWriter, r *http.Request) { return } - // FIXME(dgryski): racey once we move to a ring-buffer? + // TODO(dgryski): racey once we move to a ring-buffer? t := (int64(epoch) - Epoch0) / WindowSize if t < 0 || t >= int64(TopKs.Len()) { http.Error(w, "bad epoch", http.StatusBadRequest) diff --git a/hokud/topk.go b/hokud/topk.go index 6f3b944..175dcbb 100644 --- a/hokud/topk.go +++ b/hokud/topk.go @@ -1,6 +1,6 @@ package main -// FIXME(dgryski): this is unbounded at the moment -- limit it to 1< int(h.intervals) { - // FIXME(dgryski): could be smarter here, but it's O(log log(T)), so I'm not worried about it + // TODO(dgryski): could be smarter here, but it's O(log log(T)), so I'm not worried about it if j < len(h.timeAggregate) { h.timeAggregate[j] = nil } @@ -119,7 +119,7 @@ func (h *Hokusai) Add(epoch int64, s string, count uint32) { for j := 1; j < l; j++ { if j > int(h.intervals) { - // FIXME(dgryski): could be smarter here, but it's O(log log(T)), so I'm not worried about it + // TODO(dgryski): could be smarter here, but it's O(log log(T)), so I'm not worried about it if j < len(h.itemtimeAggregate) { h.itemtimeAggregate[j] = nil }