More Rector integration

Author: rcmcdonald91

composer.json

@@ -10,8 +10,8 @@
         "psr-4": {
             "Netgate\\": "//usr/local/pfSense/include/Netgate/",
             "pfSense\\": "//usr/local/pfSense/include/",
-	    "Utils\\Rector\\": "utils/rector/src",
-	    "Utils\\Rector\\Tests\\": "utils/rector/tests"
+	    "Utils\\Rector\\": "tools/rector/src",
+	    "Utils\\Rector\\Tests\\": "tools/rector/tests"
         }
     },
     "config": {

rector.php

@@ -1,10 +1,8 @@
 <?php
-
 declare(strict_types=1);
 
-use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
+use Utils\Rector\Rector\MyFirstRector;
 use Rector\Config\RectorConfig;
-use Rector\Set\ValueObject\LevelSetList;
 
 return static function (RectorConfig $rectorConfig): void {
     // skip third-party code
@@ -16,9 +14,6 @@
         __DIR__ . '/src',
     ]);
 
-    $rectorConfig->rule(Rector\DeadCode\Rector\Stmt\RemoveUnreachableStatementRector::class);
-
-    // $rectorConfig->rule(Rector\DeadCode\Rector\Cast\RecastingRemovalRector::class);
+    $rectorConfig->rule(MyFirstRector::class);
 
-    // $rectorConfig->rule(Rector\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector::class);
 };

tools/rector/src/Rector/MyFirstRector.php

@@ -0,0 +1,64 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Utils\Rector\Rector;
+
+use Nette\Utils\Strings;
+use PhpParser\Node;
+use PhpParser\Node\Identifier;
+use PhpParser\Node\Expr\MethodCall;
+use Rector\Core\Rector\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+final class MyFirstRector extends AbstractRector
+{
+    /**
+     * @return array<class-string<Node>>
+     */
+    public function getNodeTypes(): array
+    {
+        // what node types are we looking for?
+        // pick any node from https://github.com/rectorphp/php-parser-nodes-docs/
+        return [MethodCall::class];
+    }
+
+    /**
+     * @param MethodCall $node - we can add "MethodCall" type here, because
+     *                         only this node is in "getNodeTypes()"
+     */
+    public function refactor(Node $node): ?Node
+    {
+        // we only care about "set*" method names
+        if (! $this->isName($node->name, 'set*')) {
+            // return null to skip it
+            return null;
+        }
+
+        $methodCallName = $this->getName($node->name);
+        $newMethodCallName = Strings::replace($methodCallName, '#^set#', 'change');
+
+        $node->name = new Identifier($newMethodCallName);
+
+        // return $node if you modified it
+        return $node;
+    }
+
+    /**
+     * This method helps other to understand the rule and to generate documentation.
+     */
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition(
+            'Change method calls from set* to change*.', [
+                new CodeSample(
+                    // code before
+                    '$user->setPassword("123456");',
+                    // code after
+                    '$user->changePassword("123456");'
+                ),
+            ]
+        );
+    }
+}