Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEGIRO(v3): currency mix-up #129

Closed
64knl opened this issue Nov 20, 2024 · 4 comments · Fixed by #151
Closed

DEGIRO(v3): currency mix-up #129

64knl opened this issue Nov 20, 2024 · 4 comments · Fixed by #151
Assignees
Labels
Bug Something isn't working DEGIRO Related to DEGIRO

Comments

@64knl
Copy link

64knl commented Nov 20, 2024

When converting the script does not respect the currency reported by DEGIRO. This results in the the stock price being JPY 22.40 in the export when it should be EURO 22.40.

Datum,Tijd,Valutadatum,Product,ISIN,Omschrijving,FX,Mutatie,,Saldo,,Order Id
27-05-2024,07:41,24-05-2024,TOYOTA MOTOR CORP,JP3633400001,Dividend,,JPY,9999.99,JPY,9999.99,
27-05-2024,07:41,24-05-2024,TOYOTA MOTOR CORP,JP3633400001,Dividendbelasting,,JPY,-9999.99,JPY,-9999.99,
08-03-2024,11:25,08-03-2024,TOYOTA MOTOR CORP,JP3633400001,DEGIRO Transactiekosten en/of kosten van derden,,EUR,-9999.99,EUR,9999.99,some-guid
08-03-2024,11:25,08-03-2024,TOYOTA MOTOR CORP,JP3633400001,"Koop 30 @ 22,4 EUR",,EUR,-9999.99,EUR,9999.99,some-guid

Result (part of):

{
            "unitPrice": 22.4,
            "currency": "JPY", // should be EUR
            "dataSource": "YAHOO",
            "date": "2024-03-08T11:25:00+00:00",
            "symbol": "7203.T"
}
@dickwolff
Copy link
Owner

Your transactions (line 2 and 3) state the transaction is in JPY. The tool uses that info, so it will make it JPY. I'm not sure what more I can do here (I also think the transaction will be processed as JPY inside DEGIRO, and DEGIRO will do a currency conversion later).

@dickwolff dickwolff added the DEGIRO Related to DEGIRO label Nov 20, 2024
@64knl
Copy link
Author

64knl commented Nov 20, 2024

@dickwolff The problem is all lines are processed as JPY. Lines 4 and 5 are incorrectly processed as JPY.

@dickwolff
Copy link
Owner

dickwolff commented Jan 1, 2025

I see. This is due to the tool currently having a preference of the symbol retrieved from Yahoo Finance, instead of what's given in the export. As Toyota is listed as JPY under JP3633400001, it takes that symbol instead of the Euro (in which you bought it).

I recall adding this (the preference taking) but don't know what reason I had for it. I'll look into removing this and also look if I can find a valid reason for adding this in the first place.

EDIT: This was added due to GBP -> GBp mismatching. I'll fix this another way.

@dickwolff
Copy link
Owner

dickwolff commented Jan 1, 2025

@64knl I wonder, however, what Ghostfolio would say when you try to import it this way. Could you try to upload this file and see if Ghostfolio accepts it? My Ghostfolio says it does not have the historical currency conversion for EURJPY on that date, maybe yours has?

{
    "meta": {
        "date": "2025-01-01T14:00:04.534Z",
        "version": "v0"
    },
    "activities": [
        {
            "accountId": "aaaaaaaaaaaaaaaaaaa",
            "comment": "Dividend 27-05-2024T07:41",
            "fee": 9999.99,
            "quantity": 1,
            "type": "DIVIDEND",
            "unitPrice": 9999.99,
            "currency": "JPY",
            "dataSource": "YAHOO",
            "date": "2024-05-27T07:41:00+02:00",
            "symbol": "7203.T"
        },
        {
            "accountId": "aaaaaaaaaaaaaaaaaaa",
            "comment": "541651641",
            "fee": 9999.99,
            "quantity": 30,
            "type": "BUY",
            "unitPrice": 333.333,
            "currency": "EUR",
            "dataSource": "YAHOO",
            "date": "2024-03-08T11:25:00+01:00",
            "symbol": "7203.T"
        }
    ],
    "updateCashBalance": false
}

@dickwolff dickwolff added Bug Something isn't working Waiting for input Waiting for more input to get a sense of the issue labels Jan 1, 2025
@dickwolff dickwolff self-assigned this Jan 1, 2025
@dickwolff dickwolff removed the Waiting for input Waiting for more input to get a sense of the issue label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working DEGIRO Related to DEGIRO
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants