Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer to fetch QIDs before syncing citations #36

Open
diegodlh opened this issue Jan 29, 2021 · 0 comments
Open

Offer to fetch QIDs before syncing citations #36

diegodlh opened this issue Jan 29, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@diegodlh
Copy link
Owner

Right now source items without a QID are ignored by Citations.syncItemCitationsWithWikidata. Similarly, local citations with unknown-QID target items are ignored as well; i.e., not uploaded to Wikidata (although a Wikidata OCI may be added to them by SourceItemWrapper.addCitations if its PIDs match with that of the target item of one of the citations retrieved -#25).

Therefore, the safest flow would be to:

  1. fetch QID for all source items
  2. fetch QID for all target items
  3. only then sync citations

To make it more friendly, the syncItemCitationsWithWikidata may offer the user to run both 1 and 2 at the beginning. In this case, maybe only safest matches (i.e., single matches from PID queries, vs multiple matches #34 or title-query matches #32) should be kept, and creation of new entities for QIDs not found (#33) should not be offered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant