Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tell user if credential.id isn't a uri #134

Closed
jchartrand opened this issue Sep 17, 2024 · 1 comment
Closed

tell user if credential.id isn't a uri #134

jchartrand opened this issue Sep 17, 2024 · 1 comment
Assignees

Comments

@jchartrand
Copy link
Contributor

jchartrand commented Sep 17, 2024

Is your feature request related to a problem? Please describe.
After we update to the latest VC2 libs, VCs that don't have a uri value for their top level id will no longer verify.

Describe the solution you'd like
Add a check on the id and if it isn't a uri then display a message:

"The id of a verifiable credential must be a URI. Your credential's id is not a URI and may therefore have been issued as part of an early test pilot program. Please ask your issuer for a replacement if needed."

Describe alternatives you've considered
Could try to provide backward compatibility by modifying or working around the VC libs , but given that credentials issued thus far are for pilots, the cost of maintaining that backward compatibility is too high.

Additional Context
Same issue applies to the LCW: openwallet-foundation-labs/learner-credential-wallet#639

@alexfigtree
Copy link
Member

Done and deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (Deployed)
Development

No branches or pull requests

2 participants