Use flatten instead of filter_map

magurotuna · magurotuna · commit fbe436b1d436 · 2021-02-06T18:06:58.000+09:00
diff --git a/clippy_lints/src/loops.rs b/clippy_lints/src/loops.rs
@@ -739,7 +739,7 @@ fn combine_branches(b1: NeverLoopResult, b2: NeverLoopResult) -> NeverLoopResult
 fn never_loop_block(block: &Block<'_>, main_loop_id: HirId) -> NeverLoopResult {
     let stmts = block.stmts.iter().map(stmt_to_expr);
     let expr = once(block.expr.as_deref());
-    let mut iter = stmts.chain(expr).filter_map(|e| e);
+    let mut iter = stmts.chain(expr).flatten();
     never_loop_expr_seq(&mut iter, main_loop_id)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -739,7 +739,7 @@ fn combine_branches(b1: NeverLoopResult, b2: NeverLoopResult) -> NeverLoopResult`
`739`	`739`	`fn never_loop_block(block: &Block<'_>, main_loop_id: HirId) -> NeverLoopResult {`
`740`	`740`	`let stmts = block.stmts.iter().map(stmt_to_expr);`
`741`	`741`	`let expr = once(block.expr.as_deref());`
`742`		`- let mut iter = stmts.chain(expr).filter_map(\|e\| e);`
	`742`	`+ let mut iter = stmts.chain(expr).flatten();`
`743`	`743`	`never_loop_expr_seq(&mut iter, main_loop_id)`
`744`	`744`	`}`
`745`	`745`