Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trails randomly disappear #403

Closed
Seldom-SE opened this issue Dec 5, 2024 · 1 comment · Fixed by #404
Closed

Trails randomly disappear #403

Seldom-SE opened this issue Dec 5, 2024 · 1 comment · Fixed by #404
Labels
A - internal Internal change on a core system C - bug Something isn't working

Comments

@Seldom-SE
Copy link
Contributor

Crate versions
bevy version: 0.15.0
bevy_hanabi version: main (currently d40741e)

Describe the bug
After updating to Bevy 0.15 and bevy_hanabi main, trails randomly disappear

Expected behavior
Trails remain visible

To Reproduce
I haven't had time to tinker with this much, so I don't really know the specifics, sorry. The firework example doesn't have the issue, even when I spawn an additional instance.

Screenshots

2024-12-05.11-21-50.mp4
@djeedai
Copy link
Owner

djeedai commented Dec 5, 2024

Thanks @Seldom-SE, I've seen some weird things in the instancing example too, and I was blocking the release on that. Haven't had the time to get a smaller repro and investigate though.

@djeedai djeedai added C - bug Something isn't working A - internal Internal change on a core system labels Dec 7, 2024
djeedai added a commit that referenced this issue Dec 7, 2024
@djeedai
Fix indirect render using the wrong index
a4445a6 
Similar to the indirect update, the indirect render entry is dynamically
allocated as a continuous slice. The current code was using the global
effect index, which might be different. Adding an explicit entry into
the particle group, similar to indirect dispatch, solves the issue.

Fixes #403
@djeedai djeedai mentioned this issue Dec 7, 2024
Merged
djeedai added a commit that referenced this issue Dec 7, 2024
@djeedai
Fix indirect render using the wrong index (#404)
2666783 
Similar to the indirect update, the indirect render entry is dynamically
allocated as a continuous slice. The current code was using the global
effect index, which might be different. Adding an explicit entry into
the particle group, similar to indirect dispatch, solves the issue.

Fixes #403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A - internal Internal change on a core system C - bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix indirect render using the wrong index djeedai/bevy_hanabi
2 participants
@djeedai @Seldom-SE