Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestDeadline fails with go 1.21.3 #71

Open
solopasha opened this issue Nov 7, 2023 · 4 comments
Open

TestDeadline fails with go 1.21.3 #71

solopasha opened this issue Nov 7, 2023 · 4 comments

Comments

@solopasha
Copy link

command: go test -buildmode pie -compiler gc -ldflags " -X github.com/dlclark/regexp2/version=1.10.0 -extldflags '-Wl,-z,relro -Wl,--as-needed 
 -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redh
at/redhat-package-notes  '"
      testing: github.com/dlclark/regexp2
github.com/dlclark/regexp2
--- FAIL: TestDeadline (0.00s)
    --- FAIL: TestDeadline/1ms (0.00s)
        fastclock_test.go:31: deadline (1ms) expired too soon (after 1.067327ms)
FAIL
exit status 1
FAIL    github.com/dlclark/regexp2      1.651s
@dlclark
Copy link
Owner

dlclark commented Nov 9, 2023

What are the specs of the machine running the tests?

This test works on my machine (go v1.21.4), but I could imagine that for very slow machines the timing may be off...anything that is testing time-based delays is subject to this problem.

@solopasha
Copy link
Author

It's a ryzen 5 5600x.

@dlclark
Copy link
Owner

dlclark commented Jan 7, 2024

Is this still consistently happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants