Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger-popup: trigger node should have a themeable class #1604

Open
msssk opened this issue Dec 3, 2020 · 2 comments
Open

trigger-popup: trigger node should have a themeable class #1604

msssk opened this issue Dec 3, 2020 · 2 comments

Comments

@msssk
Copy link
Contributor

msssk commented Dec 3, 2020

Bug

The trigger node of trigger-popup should have a themeable class applied to it:

<span key="trigger" classes={fixedCss.trigger}>

Also does classes have any effect on virtual?

<virtual classes={[themedCss.root]}>

Package Version: 7.0.3, 8.0.0

@tomdye
Copy link
Member

tomdye commented Mar 22, 2021

What would the trigger class be used for? it's just a wrapper for what ever triggers the popup in order to calculate size etc. Any theming should be done on that item that's wrapped itself?

@agubler
Copy link
Member

agubler commented Mar 22, 2021

@tomdye I believe this was kind of covered by #1673, it changed the trigger to 100% width which means that it can now be constrained by the consumer (rather than overriding the size)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants