Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job scheduling: Add support for environment variables #5

Open
josegonzalez opened this issue Apr 10, 2019 · 1 comment
Open

Job scheduling: Add support for environment variables #5

josegonzalez opened this issue Apr 10, 2019 · 1 comment

Comments

@josegonzalez
Copy link
Member

josegonzalez commented Apr 10, 2019

The easy way to do this is just to add it to the env stanza. While this isn't the most secure thing to do, for many installations, this is more than enough for many users that just want HA applications.

Note that built docker images for herokuish/buildpack deploys already vendor environment variables (which should obviously be fixed, but likely won't be until Buildpack V3 becomes stable enough to replace herokuish), so we're not actually making the system much less secure by hardcoding the environment variables in the job.

@josegonzalez
Copy link
Member Author

Note that we should have the ability to turn on/off the environment variable injection. This will allow future releases of this plugin to inject custom binaries into the image to automatically pull environment variables from systems like Vault. An example implementation might be something like vaultenv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant