forked from DefectDojo/django-DefectDojo
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathtest_jira_config_engagement.py
375 lines (312 loc) · 19.8 KB
/
test_jira_config_engagement.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
# from unittest import skip
import contextlib
import logging
from unittest.mock import patch
from django.urls import reverse
# from dojo.models import JIRA_Project
from django.utils.http import urlencode
from dojo.jira_link import helper as jira_helper
from dojo.models import Engagement, Product
from .dojo_test_case import DojoTestCase
logger = logging.getLogger(__name__)
class JIRAConfigEngagementBase:
def get_new_engagement_with_jira_project_data(self):
return {
"name": "new engagement",
"description": "new description",
"lead": 1,
"product": self.product_id,
"target_start": "2070-11-27",
"target_end": "2070-12-04",
"status": "Not Started",
# 'jira-project-form-inherit_from_product': 'on', # absence = False in html forms
"jira-project-form-jira_instance": 2,
"jira-project-form-project_key": "IUNSEC",
"jira-project-form-epic_issue_type_name": "Epic",
"jira-project-form-enabled": "True",
"jira-project-form-product_jira_sla_notification": "on",
"jira-project-form-custom_fields": "null",
}
def get_new_engagement_with_jira_project_data_and_epic_mapping(self):
return {
"name": "new engagement",
"description": "new description",
"lead": 1,
"product": self.product_id,
"target_start": "2070-11-27",
"target_end": "2070-12-04",
"status": "Not Started",
# 'jira-project-form-inherit_from_product': 'on', # absence = False in html forms
"jira-project-form-jira_instance": 2,
"jira-project-form-project_key": "IUNSEC",
"jira-project-form-epic_issue_type_name": "Epic",
"jira-project-form-enabled": "True",
"jira-project-form-product_jira_sla_notification": "on",
"jira-project-form-enable_engagement_epic_mapping": "on",
"jira-epic-form-push_to_jira": "on",
"jira-project-form-custom_fields": "null",
}
def get_new_engagement_without_jira_project_data(self):
return {
"name": "new engagement",
"description": "new description",
"lead": 1,
"product": self.product_id,
"target_start": "2070-11-27",
"target_end": "2070-12-04",
"status": "Not Started",
"jira-project-form-inherit_from_product": "on",
# A value is set by default by the model, so we need to add it here as well
"jira-project-form-epic_issue_type_name": "Epic",
"jira-project-form-enabled": "True",
# 'project_key': 'IFFF',
# 'jira_instance': 2,
# 'enable_engagement_epic_mapping': 'on',
# 'push_notes': 'on',
# 'jira-project-form-product_jira_sla_notification': 'on'
}
def get_engagement_with_jira_project_data(self, engagement):
return {
"name": engagement.name,
"description": engagement.description,
"lead": 1,
"product": engagement.product.id,
"target_start": "2070-11-27",
"target_end": "2070-12-04",
"status": "Not Started",
# 'jira-project-form-inherit_from_product': 'on', # absence = False in html forms
"jira-project-form-jira_instance": 2,
"jira-project-form-project_key": "ISEC",
"jira-project-form-epic_issue_type_name": "Epic",
"jira-project-form-enabled": "True",
"jira-project-form-product_jira_sla_notification": "on",
"jira-project-form-custom_fields": "null",
}
def get_engagement_with_jira_project_data2(self, engagement):
return {
"name": engagement.name,
"description": engagement.description,
"lead": 1,
"product": engagement.product.id,
"target_start": "2070-11-27",
"target_end": "2070-12-04",
"status": "Not Started",
# 'jira-project-form-inherit_from_product': 'on', # absence = False in html forms
"jira-project-form-jira_instance": 2,
"jira-project-form-project_key": "ISEC2",
"jira-project-form-epic_issue_type_name": "Epic",
"jira-project-form-enabled": "True",
"jira-project-form-product_jira_sla_notification": "on",
"jira-project-form-custom_fields": "null",
}
def get_engagement_with_empty_jira_project_data(self, engagement):
return {
"name": engagement.name,
"description": engagement.description,
"lead": 1,
"product": engagement.product.id,
"target_start": "2070-11-27",
"target_end": "2070-12-04",
"status": "Not Started",
"jira-project-form-inherit_from_product": "on",
# A value is set by default by the model, so we need to add it here as well
"jira-project-form-epic_issue_type_name": "Epic",
"jira-project-form-enabled": "True",
# 'project_key': 'IFFF',
# 'jira_instance': 2,
# 'enable_engagement_epic_mapping': 'on',
# 'push_notes': 'on',
# 'jira-project-form-product_jira_sla_notification': 'on'
}
def get_expected_redirect_engagement(self, engagement):
return f"/engagement/{engagement.id}"
def get_expected_redirect_edit_engagement(self, engagement):
return f"/engagement/edit/{engagement.id}"
def add_engagement_jira(self, data, expect_redirect_to=None, *, expect_200=False):
response = self.client.get(reverse("new_eng_for_prod", args=(self.product_id, )))
# logger.debug('before: JIRA_Project last')
# self.log_model_instance(JIRA_Project.objects.last())
if not expect_redirect_to and not expect_200:
expect_redirect_to = "/engagement/%i"
response = self.client.post(reverse("new_eng_for_prod", args=(self.product_id, )), urlencode(data), content_type="application/x-www-form-urlencoded")
# logger.debug('after: JIRA_Project last')
# self.log_model_instance(JIRA_Project.objects.last())
engagement = None
if expect_200:
self.assertEqual(response.status_code, 200)
elif expect_redirect_to:
self.assertEqual(response.status_code, 302)
try:
engagement = Engagement.objects.get(id=response.url.split("/")[-1])
except:
try:
engagement = Engagement.objects.get(id=response.url.split("/")[-2])
except:
raise ValueError("error parsing id from redirect uri: " + response.url)
self.assertEqual(response.url, (expect_redirect_to % engagement.id))
else:
self.assertEqual(response.status_code, 200)
return engagement
def add_engagement_jira_with_data(self, data, expected_delta_jira_project_db, expect_redirect_to=None, *, expect_200=False):
jira_project_count_before = self.db_jira_project_count()
response = self.add_engagement_jira(data, expect_redirect_to=expect_redirect_to, expect_200=expect_200)
self.assertEqual(self.db_jira_project_count(), jira_project_count_before + expected_delta_jira_project_db)
return response
def add_engagement_with_jira_project(self, expected_delta_jira_project_db=0, expect_redirect_to=None, *, expect_200=False):
return self.add_engagement_jira_with_data(self.get_new_engagement_with_jira_project_data(), expected_delta_jira_project_db, expect_redirect_to=expect_redirect_to, expect_200=expect_200)
def add_engagement_without_jira_project(self, expected_delta_jira_project_db=0, expect_redirect_to=None, *, expect_200=False):
return self.add_engagement_jira_with_data(self.get_new_engagement_without_jira_project_data(), expected_delta_jira_project_db, expect_redirect_to=expect_redirect_to, expect_200=expect_200)
def add_engagement_with_jira_project_and_epic_mapping(self, expected_delta_jira_project_db=0, expect_redirect_to=None, *, expect_200=False):
return self.add_engagement_jira_with_data(self.get_new_engagement_with_jira_project_data_and_epic_mapping(), expected_delta_jira_project_db, expect_redirect_to=expect_redirect_to, expect_200=expect_200)
def edit_engagement_jira(self, engagement, data, expect_redirect_to=None, *, expect_200=False):
response = self.client.get(reverse("edit_engagement", args=(engagement.id, )))
# logger.debug('before: JIRA_Project last')
# self.log_model_instance(JIRA_Project.objects.last())
response = self.client.post(reverse("edit_engagement", args=(engagement.id, )), urlencode(data), content_type="application/x-www-form-urlencoded")
# logger.debug('after: JIRA_Project last')
# self.log_model_instance(JIRA_Project.objects.last())
if expect_200:
self.assertEqual(response.status_code, 200)
elif expect_redirect_to:
self.assertRedirects(response, expect_redirect_to)
else:
self.assertEqual(response.status_code, 200)
return response
def edit_jira_project_for_engagement_with_data(self, engagement, data, expected_delta_jira_project_db=0, expect_redirect_to=None, expect_200=None):
jira_project_count_before = self.db_jira_project_count()
if not expect_redirect_to and not expect_200:
expect_redirect_to = self.get_expected_redirect_engagement(engagement)
response = self.edit_engagement_jira(engagement, data, expect_redirect_to=expect_redirect_to, expect_200=expect_200)
self.assertEqual(self.db_jira_project_count(), jira_project_count_before + expected_delta_jira_project_db)
return response
def edit_jira_project_for_engagement(self, engagement, expected_delta_jira_project_db=0, expect_redirect_to=None, *, expect_200=False):
return self.edit_jira_project_for_engagement_with_data(engagement, self.get_engagement_with_jira_project_data(engagement), expected_delta_jira_project_db, expect_redirect_to=expect_redirect_to, expect_200=expect_200)
def edit_jira_project_for_engagement2(self, engagement, expected_delta_jira_project_db=0, expect_redirect_to=None, *, expect_200=False):
return self.edit_jira_project_for_engagement_with_data(engagement, self.get_engagement_with_jira_project_data2(engagement), expected_delta_jira_project_db, expect_redirect_to=expect_redirect_to, expect_200=expect_200)
def empty_jira_project_for_engagement(self, engagement, expected_delta_jira_project_db=0, expect_redirect_to=None, *, expect_200=False, expect_error=False):
jira_project_count_before = self.db_jira_project_count()
if not expect_redirect_to and not expect_200:
expect_redirect_to = self.get_expected_redirect_engagement(engagement)
response = None
if expect_error:
with self.assertRaisesRegex(ValueError, "Not allowed to remove existing JIRA Config for an engagement"):
response = self.edit_engagement_jira(engagement, self.get_engagement_with_empty_jira_project_data(engagement), expect_redirect_to=expect_redirect_to, expect_200=expect_200)
else:
response = self.edit_engagement_jira(engagement, self.get_engagement_with_empty_jira_project_data(engagement), expect_redirect_to=expect_redirect_to, expect_200=expect_200)
self.assertEqual(self.db_jira_project_count(), jira_project_count_before + expected_delta_jira_project_db)
return response
class JIRAConfigEngagementTest(DojoTestCase, JIRAConfigEngagementBase):
fixtures = ["dojo_testdata.json"]
product_id = 999
def __init__(self, *args, **kwargs):
DojoTestCase.__init__(self, *args, **kwargs)
def setUp(self):
self.system_settings(enable_jira=True)
self.user = self.get_test_admin()
self.client.force_login(self.user)
self.user.usercontactinfo.block_execution = True
self.user.usercontactinfo.save()
# product 3 has no jira project config, double check to make sure someone didn't molest the fixture
# running this in __init__ throws database access denied error
self.product_id = 3
product = Product.objects.get(id=self.product_id)
self.assertIsNone(jira_helper.get_jira_project(product))
@patch("dojo.jira_link.views.jira_helper.is_jira_project_valid")
def test_add_jira_project_to_engagement_without_jira_project(self, jira_mock):
jira_mock.return_value = True # cannot set return_value in decorated AND have the mock into the method
# TODO: add engagement also via API, but let's focus on JIRA here
engagement = self.add_engagement_without_jira_project(expected_delta_jira_project_db=0)
self.edit_jira_project_for_engagement(engagement, expected_delta_jira_project_db=1)
self.assertEqual(jira_mock.call_count, 1)
@patch("dojo.jira_link.views.jira_helper.is_jira_project_valid")
def test_add_empty_jira_project_to_engagement_without_jira_project(self, jira_mock):
jira_mock.return_value = True # cannot set return_value in decorated AND have the mock into the method
# Prevent the exception from being raised here so that the test can be ran in parallel
with contextlib.suppress(ValueError):
engagement = self.add_engagement_without_jira_project(expected_delta_jira_project_db=0)
self.empty_jira_project_for_engagement(engagement, expected_delta_jira_project_db=0)
self.assertEqual(jira_mock.call_count, 0)
@patch("dojo.jira_link.views.jira_helper.is_jira_project_valid")
def test_edit_jira_project_to_engagement_with_jira_project(self, jira_mock):
jira_mock.return_value = True # cannot set return_value in decorated AND have the mock into the method
engagement = self.add_engagement_with_jira_project(expected_delta_jira_project_db=1)
self.edit_jira_project_for_engagement2(engagement, expected_delta_jira_project_db=0)
self.assertEqual(jira_mock.call_count, 2)
@patch("dojo.jira_link.views.jira_helper.is_jira_project_valid")
def test_edit_empty_jira_project_to_engagement_with_jira_project(self, jira_mock):
jira_mock.return_value = True # cannot set return_value in decorated AND have the mock into the method
# Prevent the exception from being raised here so that the test can be ran in parallel
with contextlib.suppress(ValueError):
engagement = self.add_engagement_with_jira_project(expected_delta_jira_project_db=1)
# clearing out jira config used to be possible. what todo?
# - delete jira project? would disconnect all existing jira issues in defect dojo from the config?
# - allow jira project with empty jira instance and/or empty project_key? unpredictable behaviour
# - so prevent clearing out these values
# response = self.empty_jira_project_for_engagement(Engagement.objects.get(id=3), -1)
# expecting ValueError as we can't delete existing JIRA Projects
self.empty_jira_project_for_engagement(engagement, expected_delta_jira_project_db=0, expect_error=True)
self.assertEqual(jira_mock.call_count, 1)
@patch("dojo.jira_link.views.jira_helper.is_jira_project_valid")
def test_add_jira_project_to_engagement_without_jira_project_invalid_project(self, jira_mock):
jira_mock.return_value = False # cannot set return_value in decorated AND have the mock into the method
# errors means it won't redirect to view_engagement, but returns a 200 and redisplays the edit engagement page
self.edit_jira_project_for_engagement(Engagement.objects.get(id=3), expected_delta_jira_project_db=0, expect_200=True)
self.assertEqual(jira_mock.call_count, 1)
@patch("dojo.jira_link.views.jira_helper.is_jira_project_valid")
def test_edit_jira_project_to_engagement_with_jira_project_invalid_project(self, jira_mock):
jira_mock.return_value = True # cannot set return_value in decorated AND have the mock into the method
engagement = self.add_engagement_with_jira_project(expected_delta_jira_project_db=1)
jira_mock.return_value = False
# jira key is changed, so jira project will be checked
self.edit_jira_project_for_engagement2(engagement, expected_delta_jira_project_db=0, expect_200=True)
self.assertEqual(jira_mock.call_count, 2)
@patch("dojo.jira_link.views.jira_helper.is_jira_project_valid")
def test_add_engagement_with_jira_project(self, jira_mock):
jira_mock.return_value = True # cannot set return_value in decorated AND have the mock into the method
engagement = self.add_engagement_with_jira_project(expected_delta_jira_project_db=1)
self.assertIsNotNone(engagement)
self.assertEqual(jira_mock.call_count, 1)
@patch("dojo.jira_link.views.jira_helper.is_jira_project_valid")
def test_add_engagement_with_jira_project_invalid_jira_project(self, jira_mock):
jira_mock.return_value = False # cannot set return_value in decorated AND have the mock into the method
engagement = self.add_engagement_with_jira_project(expected_delta_jira_project_db=0, expect_redirect_to="/engagement/%i/edit")
# engagement still added even while jira errors
self.assertIsNotNone(engagement)
self.assertEqual(jira_mock.call_count, 1)
@patch("dojo.jira_link.views.jira_helper.is_jira_project_valid")
def test_add_engagement_without_jira_project(self, jira_mock):
jira_mock.return_value = True # cannot set return_value in decorated AND have the mock into the method
engagement = self.add_engagement_without_jira_project(expected_delta_jira_project_db=0)
self.assertIsNotNone(engagement)
self.assertEqual(jira_mock.call_count, 0)
# with jira disabled the jiraform should not be checked at all
@patch("dojo.forms.JIRAProjectForm.is_valid")
def test_add_engagement_with_jira_project_to_engagement_jira_disabled(self, jira_mock):
jira_mock.return_value = True # cannot set return_value in decorated AND have the mock into the method
self.system_settings(enable_jira=False)
engagement = self.add_engagement_with_jira_project(expected_delta_jira_project_db=0)
self.assertIsNotNone(engagement)
self.assertEqual(jira_mock.call_count, 0)
# with jira disabled the jiraform should not be checked at all
@patch("dojo.forms.JIRAProjectForm.is_valid")
def test_edit_jira_project_to_engagement_with_jira_project_invalid_project_jira_disabled(self, jira_mock):
self.system_settings(enable_jira=False)
jira_mock.return_value = True # cannot set return_value in decorated AND have the mock into the method
self.edit_jira_project_for_engagement(Engagement.objects.get(id=3), expected_delta_jira_project_db=0)
self.edit_jira_project_for_engagement2(Engagement.objects.get(id=3), expected_delta_jira_project_db=0)
self.assertEqual(jira_mock.call_count, 0)
# inheriting a JIRA Project config from a product can influence some logic and field mandatoriness etc.
# so run all the same test again, but with the product above it having a JIRA Project Config
class JIRAConfigEngagementTest_Inheritance(JIRAConfigEngagementTest):
def __init__(self, *args, **kwargs):
JIRAConfigEngagementTest.__init__(self, *args, **kwargs)
@patch("dojo.jira_link.views.jira_helper.is_jira_project_valid")
def setUp(self, jira_mock, *args, **kwargs):
jira_mock.return_value = True
JIRAConfigEngagementTest.setUp(self, *args, **kwargs)
# product 2 has jira project config, double check to make sure someone didn't molest the fixture
self.product_id = 2
product = Product.objects.get(id=self.product_id)
self.assertIsNotNone(jira_helper.get_jira_project(product))
# TODO: UI
# linking / unlinking