Bug 1792959 - fix SVGImageElement::HasValidDimensions if we're displa…

…y:none or not in a document r=emilio,chunmin

Differential Revision: https://phabricator.services.mozilla.com/D159635

dom/media/webcodecs/VideoFrame.cpp

@@ -1264,6 +1264,12 @@ already_AddRefed<VideoFrame> VideoFrame::Constructor(
     return nullptr;
   }
 
+  // Check the image width and height.
+  if (!aSVGImageElement.HasValidDimensions()) {
+    aRv.ThrowInvalidStateError("The SVG does not have valid dimensions");
+    return nullptr;
+  }
+
   // If the origin of SVGImageElement's image data is not same origin with the
   // entry settings object's origin, then throw a SecurityError DOMException.
   SurfaceFromElementResult res = nsLayoutUtils::SurfaceFromElement(
@@ -1279,8 +1285,6 @@ already_AddRefed<VideoFrame> VideoFrame::Constructor(
     aRv.ThrowInvalidStateError("The SVG's surface acquisition failed");
     return nullptr;
   }
-  // bug 1792959: `aSVGImageElement.HasValidDimensions()` can crash here. Delay
-  // the image width and height checks to `InitializeFrameWithResourceAndSize`.
 
   if (!aInit.mTimestamp.WasPassed()) {
     aRv.ThrowTypeError("Missing timestamp");

dom/svg/SVGImageElement.cpp

@@ -292,12 +292,16 @@ already_AddRefed<Path> SVGImageElement::BuildPath(PathBuilder* aBuilder) {
 bool SVGImageElement::HasValidDimensions() const {
   float width, height;
 
-  DebugOnly<bool> ok =
-      SVGGeometryProperty::ResolveAll<SVGT::Width, SVGT::Height>(this, &width,
-                                                                 &height);
-  MOZ_ASSERT(ok, "SVGGeometryProperty::ResolveAll failed");
-
-  return width > 0 && height > 0;
+  if (SVGGeometryProperty::ResolveAll<SVGT::Width, SVGT::Height>(this, &width,
+                                                                 &height)) {
+    return width > 0 && height > 0;
+  }
+  // This function might be called for an element in display:none subtree
+  // (e.g. SMIL animateMotion), we fall back to use SVG attributes.
+  return (!mLengthAttributes[ATTR_WIDTH].IsExplicitlySet() ||
+          mLengthAttributes[ATTR_WIDTH].GetAnimValInSpecifiedUnits() > 0) &&
+         (!mLengthAttributes[ATTR_HEIGHT].IsExplicitlySet() ||
+          mLengthAttributes[ATTR_HEIGHT].GetAnimValInSpecifiedUnits() > 0);
 }
 
 SVGElement::LengthAttributesInfo SVGImageElement::GetLengthInfo() {