From 94188a70731c0ee1e6e1330fc9e821ced2920865 Mon Sep 17 00:00:00 2001 From: Gerald Squelart Date: Fri, 21 Sep 2018 10:00:59 +0000 Subject: [PATCH] Bug 1493017 - Tweak vscode tasks.json problemMatcher regexes to handle clang/Windows output - r=jya The original regex could match linux&mac outputs that look like: `/[...]/ffmpeg/FFmpegVideoDecoder.cpp:315:6: error: expected expression` However on Windows the same outputs have a different line&column format: `c:/[...]/ffmpeg/FFmpegVideoDecoder.cpp(315,7): error: expected expression` Differential Revision: https://phabricator.services.mozilla.com/D6442 --HG-- extra : moz-landing-system : lando --- .vscode/tasks.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.vscode/tasks.json b/.vscode/tasks.json index c95d7a00f66a1..2cc689541010d 100644 --- a/.vscode/tasks.json +++ b/.vscode/tasks.json @@ -31,7 +31,7 @@ "owner": "cpp", "fileLocation": "absolute", "pattern": { - "regexp": "^.*?([^\\s]*):(\\d+):(\\d+):\\s+(warning|error):\\s+(.*)$", + "regexp": "^.*?([^\\s]*)[:(](\\d+)[:,](\\d+)[)]?:\\s+(warning|error):\\s+(.*)$", "file": 1, "line": 2, "column": 3, @@ -52,7 +52,7 @@ "owner": "cpp", "fileLocation": "absolute", "pattern": { - "regexp": "^(.*):(\\d+):(\\d+):\\s+(warning|error):\\s+(.*)$", + "regexp": "^(.*)[:(](\\d+)[:,](\\d+)[)]?:\\s+(warning|error):\\s+(.*)$", "file": 1, "line": 2, "column": 3, @@ -77,7 +77,7 @@ "owner": "cpp", "fileLocation": "absolute", "pattern": { - "regexp": "^(.*):(\\d+):(\\d+):\\s+(warning|error):\\s+(.*)$", + "regexp": "^(.*)[:(](\\d+)[:,](\\d+)[)]?:\\s+(warning|error):\\s+(.*)$", "file": 1, "line": 2, "column": 3,