Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbw fails to build due to crate Region failing to build #105

Closed
nikkicoon opened this issue Feb 24, 2023 · 11 comments
Closed

rbw fails to build due to crate Region failing to build #105

nikkicoon opened this issue Feb 24, 2023 · 11 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@nikkicoon
Copy link

nikkicoon commented Feb 24, 2023

I'm trying to package rbw for pkgsrc (I'm building on NetBSD/amd64, but it's a multi platform system PM).

It currently fails to build, I've reported this upstream at darfink/region-rs#23 but it looks like after 1 year no commits that the crate has been abandoned by its developer.

Old log included in upstream link, new log:

   Compiling region v3.0.0
error[E0412]: cannot find type `QueryIter` in module `os`
 --> /usr/work/security/rbw/work/vendor/region-3.0.0/src/query.rs:7:24
  |
7 |   iterator: Option<os::QueryIter>,
  |                        ^^^^^^^^^ not found in `os`
  |
help: consider importing this struct
  |
1 | use crate::QueryIter;
  |
help: if you import `QueryIter`, refer to it directly
  |
7 -   iterator: Option<os::QueryIter>,
7 +   iterator: Option<QueryIter>,
  |

error[E0433]: failed to resolve: could not find `QueryIter` in `os`
  --> /usr/work/security/rbw/work/vendor/region-3.0.0/src/query.rs:15:9
   |
15 |     os::QueryIter::new(origin, size).map(|iterator| Self {
   |         ^^^^^^^^^ not found in `os`
   |
help: consider importing this struct
   |
1  | use crate::QueryIter;
   |
help: if you import `QueryIter`, refer to it directly
   |
15 -     os::QueryIter::new(origin, size).map(|iterator| Self {
15 +     QueryIter::new(origin, size).map(|iterator| Self {
   |

Some errors have detailed explanations: E0412, E0433.
For more information about an error, try `rustc --explain E0412`.
error: could not compile `region` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
*** Error code 101

Stop.
@nikkicoon
Copy link
Author

The actual core issue might be that region needs to have a NetBSD implementation added? I haven't worked much with rust.

@doy doy added bug Something isn't working help wanted Extra attention is needed labels Jul 18, 2023
@doy
Copy link
Owner

doy commented Jul 18, 2023

yeah, it does look like the issue is a missing netbsd implementation. unfortunately, i don't have access to any netbsd machines, so i can't help here myself/:

@pfr-dev
Copy link

pfr-dev commented Jan 31, 2024

I'm getting the exact same error. Would love to use rbw on NetBSD. Might try rally some support in the BSD community.

@0323pin
Copy link

0323pin commented Jan 31, 2024

@pfr-dev this, darfink/region-rs#14 fixes it but, it hasn't been merged.

@0323pin
Copy link

0323pin commented Jan 31, 2024

@nikkicoon and @pfr-dev, I've just pushed a package to the wip-repository, please do some testing.

@pfr-dev
Copy link

pfr-dev commented Feb 1, 2024

@nikkicoon and @pfr-dev, I've just pushed a package to the wip-repository, please do some testing.

Thanks! I can confirm this is working on NetBSD 9.3_Stable

@0323pin
Copy link

0323pin commented Feb 1, 2024

I've now merged the package into the main branch.

It would be good to get that commit merged into region, though. Carrying this workaround for a long time may turn out painful.

@pfr-dev
Copy link

pfr-dev commented Mar 12, 2024

It would be good to get that commit merged into region, though.

Patch has been merged and a new release tag v3.0.1 created.

Thanks @0323pin !

@doy
Copy link
Owner

doy commented Apr 20, 2024

i've bumped the region dependency in 5c47355, and this should be included in the 1.10 release. thanks for the work here!

@doy doy closed this as completed Apr 20, 2024
@0323pin
Copy link

0323pin commented Apr 20, 2024

@doy Thanks!
Is a new release planned?

@doy
Copy link
Owner

doy commented Apr 20, 2024

just released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants