Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version of 'rbw' struggles with lower case ([a-z]) TOTP secrets and ones with padding - trailing equal signs ('=') #191

Closed
rjc opened this issue Jul 2, 2024 · 1 comment

Comments

@rjc
Copy link

rjc commented Jul 2, 2024

Hello,

As per the title/subject, the latest version of rbw stopped generating TOTP codes for secrets comprised of lower case letters ([a-z]) as well as ones with padding - trailing equal signs (=). It now gives this error instead:

rbw code: totp secret was not valid base32

Whilst Base32 does actually use upper case letters, some online providers generate the TOTP secrets in lower case, namely Google, so changing all secrets from lower to upper case, feel sub-optimal, not to mention convincing said providers to change the way they generate TOTP secrets ;^)

As to padding - a TOTP shares secret with ==== padding is valid.

BTW, everything worked fine, at least, up to rbw version 1.10.2, and it would be great to restore the old behaviour.

Regards,

rjc

@rjc
Copy link
Author

rjc commented Jul 3, 2024

I hadn't tested it yet but, it looks like #189 fixes the former.

@doy doy closed this as completed in 92adeed Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant