[REM] Unnecessary size parameters on char fields

Author: Jaydeep Barot

addons/account/account.py

@@ -33,7 +33,7 @@ class account_analytic_line(osv.osv):
         'move_id': fields.many2one('account.move.line', 'Move Line', ondelete='cascade', select=True),
         'journal_id': fields.many2one('account.analytic.journal', 'Analytic Journal', required=True, ondelete='restrict', select=True),
         'code': fields.char('Code', size=8),
-        'ref': fields.char('Ref.', size=64),
+        'ref': fields.char('Ref.'),
         'currency_id': fields.related('move_id', 'currency_id', type='many2one', relation='res.currency', string='Account Currency', store=True, help="The related account currency if not equal to the company one.", readonly=True),
         'amount_currency': fields.related('move_id', 'amount_currency', type='float', string='Amount Currency', store=True, help="The amount expressed in the related account currency if not equal to the company one.", readonly=True),
     }

addons/account/account_analytic_line.py

@@ -114,7 +114,7 @@ def _all_lines_reconciled(self, cr, uid, ids, name, args, context=None):
     _description = "Bank Statement"
     _inherit = ['mail.thread']
     _columns = {
-        'name': fields.char('Reference', size=64, states={'draft': [('readonly', False)]}, readonly=True, help='if you give the Name other then /, its created Accounting Entries Move will be with same name as statement name. This allows the statement entries to have the same references than the statement itself'), # readonly for account_cash_statement
+        'name': fields.char('Reference', states={'draft': [('readonly', False)]}, readonly=True, help='if you give the Name other then /, its created Accounting Entries Move will be with same name as statement name. This allows the statement entries to have the same references than the statement itself'), # readonly for account_cash_statement
         'date': fields.date('Date', required=True, states={'confirm': [('readonly', True)]}, select=True),
         'journal_id': fields.many2one('account.journal', 'Journal', required=True,
             readonly=True, states={'draft':[('readonly',False)]}),

addons/account/account_bank_statement.py

@@ -97,7 +97,7 @@ def _get_balance(self, cr, uid, ids, field_names, args, context=None):
         return res
 
     _columns = {
-        'name': fields.char('Report Name', size=128, required=True, translate=True),
+        'name': fields.char('Report Name', required=True, translate=True),
         'parent_id': fields.many2one('account.financial.report', 'Parent'),
         'children_ids':  fields.one2many('account.financial.report', 'parent_id', 'Account Report'),
         'sequence': fields.integer('Sequence'),

addons/account/account_financial_report.py

@@ -226,8 +226,8 @@ def _get_invoice_from_reconcile(self, cr, uid, ids, context=None):
         },
     }
     _columns = {
-        'name': fields.char('Reference/Description', size=64, select=True, readonly=True, states={'draft':[('readonly',False)]}),
-        'origin': fields.char('Source Document', size=64, help="Reference of the document that produced this invoice.", readonly=True, states={'draft':[('readonly',False)]}),
+        'name': fields.char('Reference/Description', select=True, readonly=True, states={'draft':[('readonly',False)]}),
+        'origin': fields.char('Source Document', help="Reference of the document that produced this invoice.", readonly=True, states={'draft':[('readonly',False)]}),
         'supplier_invoice_number': fields.char('Supplier Invoice Number', size=64, help="The reference of this invoice as provided by the supplier.", readonly=True, states={'draft':[('readonly',False)]}),
         'type': fields.selection([
             ('out_invoice','Customer Invoice'),
@@ -237,8 +237,8 @@ def _get_invoice_from_reconcile(self, cr, uid, ids, context=None):
             ],'Type', readonly=True, select=True, change_default=True, track_visibility='always'),
 
         'number': fields.related('move_id','name', type='char', readonly=True, size=64, relation='account.move', store=True, string='Number'),
-        'internal_number': fields.char('Invoice Number', size=32, readonly=True, help="Unique number of the invoice, computed automatically when the invoice is created."),
-        'reference': fields.char('Invoice Reference', size=64, help="The partner reference of this invoice."),
+        'internal_number': fields.char('Invoice Number', readonly=True, help="Unique number of the invoice, computed automatically when the invoice is created."),
+        'reference': fields.char('Invoice Reference', help="The partner reference of this invoice."),
         'reference_type': fields.selection(_get_reference_type, 'Payment Reference',
             required=True, readonly=True, states={'draft':[('readonly',False)]}),
         'comment': fields.text('Additional Information'),
@@ -318,7 +318,7 @@ def _get_invoice_from_reconcile(self, cr, uid, ids, context=None):
             },
             help="Remaining amount due."),
         'payment_ids': fields.function(_compute_lines, relation='account.move.line', type="many2many", string='Payments'),
-        'move_name': fields.char('Journal Entry', size=64, readonly=True, states={'draft':[('readonly',False)]}),
+        'move_name': fields.char('Journal Entry', readonly=True, states={'draft':[('readonly',False)]}),
         'user_id': fields.many2one('res.users', 'Salesperson', readonly=True, track_visibility='onchange', states={'draft':[('readonly',False)]}),
         'fiscal_position': fields.many2one('account.fiscal.position', 'Fiscal Position', readonly=True, states={'draft':[('readonly',False)]}),
         'commercial_partner_id': fields.related('partner_id', 'commercial_partner_id', string='Commercial Entity', type='many2one',
@@ -1402,7 +1402,7 @@ def _price_unit_default(self, cr, uid, context=None):
     _order = "invoice_id,sequence,id"
     _columns = {
         'name': fields.text('Description', required=True),
-        'origin': fields.char('Source Document', size=256, help="Reference of the document that produced this invoice."),
+        'origin': fields.char('Source Document', help="Reference of the document that produced this invoice."),
         'sequence': fields.integer('Sequence', help="Gives the sequence of this line when displaying the invoice."),
         'invoice_id': fields.many2one('account.invoice', 'Invoice Reference', ondelete='cascade', select=True),
         'uos_id': fields.many2one('product.uom', 'Unit of Measure', ondelete='set null', select=True),
@@ -1646,7 +1646,7 @@ def _count_factor(self, cr, uid, ids, name, args, context=None):
 
     _columns = {
         'invoice_id': fields.many2one('account.invoice', 'Invoice Line', ondelete='cascade', select=True),
-        'name': fields.char('Tax Description', size=64, required=True),
+        'name': fields.char('Tax Description', required=True),
         'account_id': fields.many2one('account.account', 'Tax Account', required=True, domain=[('type','<>','view'),('type','<>','income'), ('type', '<>', 'closed')]),
         'account_analytic_id': fields.many2one('account.analytic.account', 'Analytic account'),
         'base': fields.float('Base', digits_compute=dp.get_precision('Account')),

addons/account/account_invoice.py

@@ -445,7 +445,7 @@ def _get_move_from_reconcile(self, cr, uid, ids, context=None):
 
 
     _columns = {
-        'name': fields.char('Name', size=64, required=True),
+        'name': fields.char('Name', required=True),
         'quantity': fields.float('Quantity', digits=(16,2), help="The optional quantity expressed by this line, eg: number of product sold. The quantity is not a legal requirement but is very useful for some reports."),
         'product_uom_id': fields.many2one('product.uom', 'Unit of Measure'),
         'product_id': fields.many2one('product.product', 'Product'),
@@ -454,7 +454,7 @@ def _get_move_from_reconcile(self, cr, uid, ids, context=None):
         'account_id': fields.many2one('account.account', 'Account', required=True, ondelete="cascade", domain=[('type','<>','view'), ('type', '<>', 'closed')], select=2),
         'move_id': fields.many2one('account.move', 'Journal Entry', ondelete="cascade", help="The move of this entry line.", select=2, required=True),
         'narration': fields.related('move_id','narration', type='text', relation='account.move', string='Internal Note'),
-        'ref': fields.related('move_id', 'ref', string='Reference', type='char', size=64, store=True),
+        'ref': fields.related('move_id', 'ref', string='Reference', type='char', store=True),
         'statement_id': fields.many2one('account.bank.statement', 'Statement', help="The bank statement used for bank reconciliation", select=1),
         'reconcile_id': fields.many2one('account.move.reconcile', 'Reconcile', readonly=True, ondelete='set null', select=2),
         'reconcile_partial_id': fields.many2one('account.move.reconcile', 'Partial Reconcile', readonly=True, ondelete='set null', select=2),

addons/account/account_move_line.py

@@ -28,7 +28,7 @@ class account_fiscal_position(osv.osv):
     _name = 'account.fiscal.position'
     _description = 'Fiscal Position'
     _columns = {
-        'name': fields.char('Fiscal Position', size=64, required=True),
+        'name': fields.char('Fiscal Position', required=True),
         'active': fields.boolean('Active', help="By unchecking the active field, you may hide a fiscal position without deleting it."),
         'company_id': fields.many2one('res.company', 'Company'),
         'account_ids': fields.one2many('account.fiscal.position.account', 'position_id', 'Account Mapping'),

addons/account/partner.py

@@ -25,10 +25,10 @@ class account_analytic_journal(osv.osv):
     _name = 'account.analytic.journal'
     _description = 'Analytic Journal'
     _columns = {
-        'name': fields.char('Journal Name', size=64, required=True),
+        'name': fields.char('Journal Name', required=True),
         'code': fields.char('Journal Code', size=8),
         'active': fields.boolean('Active', help="If the active field is set to False, it will allow you to hide the analytic journal without removing it."),
-        'type': fields.selection([('sale','Sale'), ('purchase','Purchase'), ('cash','Cash'), ('general','General'), ('situation','Situation')], 'Type', size=32, required=True, help="Gives the type of the analytic journal. When it needs for a document (eg: an invoice) to create analytic entries, OpenERP will look for a matching journal of the same type."),
+        'type': fields.selection([('sale','Sale'), ('purchase','Purchase'), ('cash','Cash'), ('general','General'), ('situation','Situation')], 'Type', required=True, help="Gives the type of the analytic journal. When it needs for a document (eg: an invoice) to create analytic entries, OpenERP will look for a matching journal of the same type."),
         'line_ids': fields.one2many('account.analytic.line', 'journal_id', 'Lines'),
         'company_id': fields.many2one('res.company', 'Company', required=True),
     }

addons/account/project/project.py

@@ -32,7 +32,7 @@ class account_entries_report(osv.osv):
         'date': fields.date('Effective Date', readonly=True),
         'date_created': fields.date('Date Created', readonly=True),
         'date_maturity': fields.date('Date Maturity', readonly=True),
-        'ref': fields.char('Reference', size=64, readonly=True),
+        'ref': fields.char('Reference', readonly=True),
         'nbr': fields.integer('# of Items', readonly=True),
         'debit': fields.float('Debit', readonly=True),
         'credit': fields.float('Credit', readonly=True),

addons/account/report/account_entries_report.py

@@ -73,7 +73,7 @@ class temp_range(osv.osv):
     _description = 'A Temporary table used for Dashboard view'
 
     _columns = {
-        'name': fields.char('Range',size=64)
+        'name': fields.char('Range')
     }
 
 
@@ -112,7 +112,7 @@ def _calc_bal(self, cr, uid, ids, name, args, context=None):
         return res
 
     _columns = {
-        'name': fields.char('Month Range', size=7, readonly=True),
+        'name': fields.char('Month Range', size=24, readonly=True),
         'balance': fields.function(_calc_bal, string='Balance', readonly=True),
     }
 
@@ -151,14 +151,14 @@ class report_invoice_created(osv.osv):
     _description = "Report of Invoices Created within Last 15 days"
     _auto = False
     _columns = {
-        'name': fields.char('Description', size=64, readonly=True),
+        'name': fields.char('Description', readonly=True),
         'type': fields.selection([
             ('out_invoice','Customer Invoice'),
             ('in_invoice','Supplier Invoice'),
             ('out_refund','Customer Refund'),
             ('in_refund','Supplier Refund'),
             ],'Type', readonly=True),
-        'number': fields.char('Invoice Number', size=32, readonly=True),
+        'number': fields.char('Invoice Number', readonly=True),
         'partner_id': fields.many2one('res.partner', 'Partner', readonly=True),
         'amount_untaxed': fields.float('Untaxed', readonly=True),
         'amount_total': fields.float('Total', readonly=True),
@@ -174,7 +174,7 @@ class report_invoice_created(osv.osv):
             ('paid','Done'),
             ('cancel','Cancelled')
         ],'Status', readonly=True),
-        'origin': fields.char('Source Document', size=64, readonly=True, help="Reference of the document that generated this invoice report."),
+        'origin': fields.char('Source Document', readonly=True, help="Reference of the document that generated this invoice report."),
         'create_date': fields.datetime('Create Date', readonly=True)
     }
     _order = 'create_date'
@@ -203,7 +203,7 @@ class report_account_type_sales(osv.osv):
     _description = "Report of the Sales by Account Type"
     _auto = False
     _columns = {
-        'name': fields.char('Year', size=64, required=False, readonly=True),
+        'name': fields.char('Year', required=False, readonly=True),
         'period_id': fields.many2one('account.period', 'Force Period', readonly=True),
         'product_id': fields.many2one('product.product', 'Product', readonly=True),
         'quantity': fields.float('Quantity', readonly=True),
@@ -244,7 +244,7 @@ class report_account_sales(osv.osv):
     _description = "Report of the Sales by Account"
     _auto = False
     _columns = {
-        'name': fields.char('Year', size=64, required=False, readonly=True, select=True),
+        'name': fields.char('Year', required=False, readonly=True, select=True),
         'period_id': fields.many2one('account.period', 'Force Period', readonly=True),
         'product_id': fields.many2one('product.product', 'Product', readonly=True),
         'quantity': fields.float('Quantity', readonly=True),

addons/account/report/account_report.py

@@ -30,7 +30,7 @@ class accounting_report(osv.osv_memory):
     _columns = {
         'enable_filter': fields.boolean('Enable Comparison'),
         'account_report_id': fields.many2one('account.financial.report', 'Account Reports', required=True),
-        'label_filter': fields.char('Column Label', size=32, help="This label will be displayed on report to show the balance computed for the given comparison filter."),
+        'label_filter': fields.char('Column Label', help="This label will be displayed on report to show the balance computed for the given comparison filter."),
         'fiscalyear_id_cmp': fields.many2one('account.fiscalyear', 'Fiscal Year', help='Keep empty for all open fiscal year'),
         'filter_cmp': fields.selection([('filter_no', 'No Filters'), ('filter_date', 'Date'), ('filter_period', 'Periods')], "Filter by", required=True),
         'period_from_cmp': fields.many2one('account.period', 'Start Period'),

addons/account/wizard/account_financial_report.py

@@ -35,7 +35,7 @@ class account_fiscalyear_close(osv.osv_memory):
                                  'New Fiscal Year', required=True),
        'journal_id': fields.many2one('account.journal', 'Opening Entries Journal', domain="[('type','=','situation')]", required=True, help='The best practice here is to use a journal dedicated to contain the opening entries of all fiscal years. Note that you should define it with default debit/credit accounts, of type \'situation\' and with a centralized counterpart.'),
        'period_id': fields.many2one('account.period', 'Opening Entries Period', required=True),
-       'report_name': fields.char('Name of new entries',size=64, required=True, help="Give name of the new entries"),
+       'report_name': fields.char('Name of new entries', required=True, help="Give name of the new entries"),
     }
     _defaults = {
         'report_name': lambda self, cr, uid, context: _('End of Fiscal Year Entry'),

addons/account/wizard/account_fiscalyear_close.py

@@ -34,7 +34,7 @@ class account_invoice_refund(osv.osv_memory):
        'date': fields.date('Date', help='This date will be used as the invoice date for credit note and period will be chosen accordingly!'),
        'period': fields.many2one('account.period', 'Force period'),
        'journal_id': fields.many2one('account.journal', 'Refund Journal', help='You can select here the journal to use for the credit note that will be created. If you leave that field empty, it will use the same journal as the current invoice.'),
-       'description': fields.char('Reason', size=128, required=True),
+       'description': fields.char('Reason', required=True),
        'filter_refund': fields.selection([('refund', 'Create a draft refund'), ('cancel', 'Cancel: create refund and reconcile'),('modify', 'Modify: create refund, reconcile and create a new draft invoice')], "Refund Method", required=True, help='Refund base on this type. You can not Modify and Cancel if the invoice is already reconciled'),
     }
 

addons/account/wizard/account_invoice_refund.py

@@ -107,7 +107,7 @@ class account_move_line_reconcile_writeoff(osv.osv_memory):
         'journal_id': fields.many2one('account.journal','Write-Off Journal', required=True),
         'writeoff_acc_id': fields.many2one('account.account','Write-Off account', required=True),
         'date_p': fields.date('Date'),
-        'comment': fields.char('Comment', size= 64, required=True),
+        'comment': fields.char('Comment', required=True),
         'analytic_id': fields.many2one('account.analytic.account', 'Analytic Account', domain=[('parent_id', '!=', False)]),
     }
     _defaults = {

addons/account/wizard/account_reconcile.py

@@ -5,7 +5,7 @@
 class CashBox(osv.osv_memory):
     _register = False
     _columns = {
-        'name' : fields.char('Reason', size=64, required=True),
+        'name' : fields.char('Reason', required=True),
         # Attention, we don't set a domain, because there is a journal_type key 
         # in the context of the action
         'amount' : fields.float('Amount',
@@ -49,7 +49,7 @@ class CashBoxIn(CashBox):
 
     _columns = CashBox._columns.copy()
     _columns.update({
-        'ref' : fields.char('Reference', size=32),
+        'ref' : fields.char('Reference'),
     })
 
     def _compute_values_for_statement_line(self, cr, uid, box, record, context=None):

addons/account/wizard/pos_box.py

@@ -70,7 +70,7 @@ class account_analytic_plan(osv.osv):
     _name = "account.analytic.plan"
     _description = "Analytic Plan"
     _columns = {
-        'name': fields.char('Analytic Plan', size=64, required=True, select=True),
+        'name': fields.char('Analytic Plan', required=True, select=True),
         'plan_ids': fields.one2many('account.analytic.plan.line', 'plan_id', 'Analytic Plans'),
     }
 
@@ -81,7 +81,7 @@ class account_analytic_plan_line(osv.osv):
     _order = "sequence, id"
     _columns = {
         'plan_id': fields.many2one('account.analytic.plan','Analytic Plan',required=True),
-        'name': fields.char('Axis Name', size=64, required=True, select=True),
+        'name': fields.char('Axis Name', required=True, select=True),
         'sequence': fields.integer('Sequence'),
         'root_analytic_id': fields.many2one('account.analytic.account', 'Root Account', help="Root account of this plan.", required=False),
         'min_required': fields.float('Minimum Allowed (%)'),
@@ -97,7 +97,7 @@ class account_analytic_plan_instance(osv.osv):
     _name = "account.analytic.plan.instance"
     _description = "Analytic Plan Instance"
     _columns = {
-        'name': fields.char('Analytic Distribution', size=64),
+        'name': fields.char('Analytic Distribution'),
         'code': fields.char('Distribution Code', size=16),
         'journal_id': fields.many2one('account.analytic.journal', 'Analytic Journal' ),
         'account_ids': fields.one2many('account.analytic.plan.instance.line', 'plan_id', 'Account Id'),