Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a pkgconfig template #7

Open
GoogleCodeExporter opened this issue Mar 25, 2015 · 6 comments
Open

add a pkgconfig template #7

GoogleCodeExporter opened this issue Mar 25, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

In the Linux ecosystem npapi plugins are often built using devel package 
instead of adding the headers to its own source code.
Up to now these applications checked for mozilla-plugin.pc for example which 
was pretty much standardized between Linux distributions.
With the new release model and this npapi-sdk reference project it makes sense 
to provide this a development package in a Linux build environment. But it does 
not yet contain a pkgconfig template. The contents of that file are pretty 
obvious in the Linux environment but to have a standard naming of the pkgconfig 
file it makes sense to add a template file which makes it clear so that this is 
consistent through different Linux distributions which makes it a lot easier 
for upstream plugin authors to add another pkgconfig check in their buildsystem.

For the upcoming version of openSUSE I've added the headers as devel package 
named npapi-sdk to the distribution and also I'm using the pkgconfig name 
npapi-sdk.pc as well. But right now we have to patch the other applications 
ourselves because it's not clear how other distributions will name the 
pkgconfig file.

Original issue reported on code.google.com by [email protected] on 20 Aug 2011 at 8:08

@GoogleCodeExporter
Copy link
Author

Right now, the pkg-config filenames are broken by design. I guess Mozilla 
thinks it's funny when random packages look for 6 different pkgconfig package 
names to find NPAPI headers, and I don't think adding 7th there is really a 
good solution. I'd go with using 'mozilla-plugin' which seems to be the most 
widespread one.

Original comment by [email protected] on 30 Aug 2011 at 4:23

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

My implementation:
- https://github.com/mgorny/npapi-sdk/commit/66c583ee27

Though it will still need a few more commits to make any real-life plugin 
buildable with it.

Original comment by [email protected] on 30 Aug 2011 at 5:04

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Gentoo contributor - I'm really happy that you're interested in helping here 
(thanks for the patch), but please keep it professional. No need for the snarky 
comments. We're also just trying to help and perhaps not responsible for what 
you think we are anyway.

I'd be happy to take a patch for this, let me know when it is done and ask 
Wolfgang (the reporter of this bug) for review?

Original comment by [email protected] on 1 Sep 2011 at 4:34

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Ok, after some discussion I've recreated the patch to use a clean, new 
npapi-sdk.pc file for it. This patch relies on my other autotools patch but the 
file can be rebased easily if you're really against having a buildsystem. But 
please remember to replace @VERSION@ with the actual NPAPI version (0.27) as 
some upstreams really want to be able to check for the version.

If the patch gets a clean-go, I could start requesting plugin upstreams to use 
that pkg-config file instead/next-to the random stuff they do now.

Original comment by [email protected] on 4 Sep 2011 at 10:09

  • Added labels: ****
  • Removed labels: ****

Attachments:

@GoogleCodeExporter
Copy link
Author

What Wolfgang created is 
https://build.opensuse.org/package/view_file?project=mozilla%3AFactory&package=n
papi-sdk&file=npapi-sdk.pc.in. It's basically the same, and in any case I don't 
think Wolfgang or anybody else really cares about the details. The only think 
we need is you to provide ANY pkg-config file so plugin creators can start 
searching for it.

+1 to commit Gentoo's patch.

Original comment by [email protected] on 27 Sep 2011 at 2:48

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

I don't want to argue about buildsystem or not but I'd like a de-facto standard 
with pkg-config file naming. The contents like the includedir can still be 
modified from downstream maintainers but the consuming packages should only 
have to care about one pkg-config file name. So review+ for the npapi-sdk.pc 
name and content. If it's preprocessed or not is another issue.

Original comment by [email protected] on 27 Sep 2011 at 3:02

  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant