Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail to validate new dymint header when upgrade #1296

Closed
srene opened this issue Dec 24, 2024 · 1 comment · Fixed by #1294
Closed

fail to validate new dymint header when upgrade #1296

srene opened this issue Dec 24, 2024 · 1 comment · Fixed by #1294

Comments

@srene
Copy link
Contributor

srene commented Dec 24, 2024

due to upgrade flow, header validation requires to pass validation for both previous and new drs, since the block produced with for the first block of the upgrade is created with the previous drs version. since headers are not backward compatible validation fails when upgrading to new drs and full-nodes need to validate previous drs (first after the upgrade) block, with new drs version.

@srene
Copy link
Contributor Author

srene commented Dec 24, 2024

to solve this issue it would be required to add block versions, so depending of the version of the the block a specifc validation for the specific version will need to run. however, as a temporary solution, we will add a flag for full-nodes to skip a specific block height validation, to be used with the new drs version at the upgrade height. it does not imply security threat since the block was already validated before changing to the new version binary.

@srene srene linked a pull request Dec 24, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant