-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proxysql] Secrets in ConfigMap #293
Comments
Never mind, it was a bit hidden, but I now understand how you can mount files directly into the configuration. Proposed contribution is not necessary. |
@Pionerd How did you do it? Separating user passwords from values.yaml? |
My concern was with the configMap possibly containing secrets. However, looking at it again, I probably would still expect the possibility to read the passwords from an existing secret (as opposed to helm values which is indeed not ideal). |
So, erm... how did you do it? Can you provide an example that loads a username/password from a standard k8s secret into the proxysql config? |
No, that is my point. That part is lacking. It (currently) should be supplied through Helm values. When I opened this issue, I thought it was only possible to do so through a ConfigMap, but it works via a Secret; which made my original proposal less urgent. I'm not using proxysql atm, but I think a PR to fix this is desired. |
Currently, ProxySQL stores sensitive data (e.g. user passwords) in the ConfigMap. If I were to make a PR with the below would that be merged?
The text was updated successfully, but these errors were encountered: