Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proxysql] Secrets in ConfigMap #293

Closed
Pionerd opened this issue Mar 6, 2024 · 5 comments
Closed

[proxysql] Secrets in ConfigMap #293

Pionerd opened this issue Mar 6, 2024 · 5 comments

Comments

@Pionerd
Copy link

Pionerd commented Mar 6, 2024

Currently, ProxySQL stores sensitive data (e.g. user passwords) in the ConfigMap. If I were to make a PR with the below would that be merged?

  • Either convert the ConfigMap to a Secret, or at least give that option
  • Allow sensitive data such as those passwords to be supplied separately / from existing secrets
@Pionerd
Copy link
Author

Pionerd commented Mar 9, 2024

Never mind, it was a bit hidden, but I now understand how you can mount files directly into the configuration. Proposed contribution is not necessary.

@Pionerd Pionerd closed this as completed Mar 9, 2024
@prwnd9
Copy link

prwnd9 commented Sep 9, 2024

@Pionerd How did you do it? Separating user passwords from values.yaml?

@Pionerd
Copy link
Author

Pionerd commented Sep 9, 2024

My concern was with the configMap possibly containing secrets. However, looking at it again, I probably would still expect the possibility to read the passwords from an existing secret (as opposed to helm values which is indeed not ideal).

@law
Copy link

law commented Sep 17, 2024

So, erm... how did you do it? Can you provide an example that loads a username/password from a standard k8s secret into the proxysql config?

@Pionerd
Copy link
Author

Pionerd commented Sep 17, 2024

No, that is my point. That part is lacking. It (currently) should be supplied through Helm values. When I opened this issue, I thought it was only possible to do so through a ConfigMap, but it works via a Secret; which made my original proposal less urgent. I'm not using proxysql atm, but I think a PR to fix this is desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants