Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

Setup accessibility ids #204

Open
WojciechTrzasko opened this issue Feb 18, 2016 · 1 comment
Open

Setup accessibility ids #204

WojciechTrzasko opened this issue Feb 18, 2016 · 1 comment

Comments

@WojciechTrzasko
Copy link

Hi,
First of all thanks for great tool and good work :). It is really one of my favourite pod library :).

And now let's go back to business. I have a request for a small feature, that will be very helpful. Can you add possibility to setup custom accessibility ids for title or description?

You may wonder, why I need this? Right now I have situation where on screen I have split view with tableView in both master and details view controllers. Both of them are using DNZEmptyDataSet and shows same message. It works great :).

But my problem occurs when I'm trying to add some UI test to the project. I want to separately catch situations when one of list are empty and right now both use same accessibilityId. In such case having a possiblity to define separate values for ids would be very helpful :).

@dzenbot
Copy link
Owner

dzenbot commented Feb 18, 2016

Hi @WojciechTrzasko,
I'm glad you're liking the library. Thanks for the kind words.

Your requests makes a lot of sense. Before actually getting to the bottom of the paragraph, it all made sense to me for testing purposes.
What we could do, is to define a set of enums to represent each UI outlet, and expose a very elegant data source callback like:

- (NSString *)emptyDataSet:(UIScrollView *)scrollView accessibiltyIndentifierForOutlet:(DZNEmptyDataSetOutlet)outlet;

Will that make sense? Could you give it a shot and submit a PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants