From e205a159e30c9d8980fb63d71ba272d5fcfdd565 Mon Sep 17 00:00:00 2001 From: Simon Coggins Date: Tue, 22 Apr 2014 14:11:52 +1200 Subject: [PATCH] MDL-45212 scorm: Disable sorting on unsortable columns in SCORM reports --- mod/scorm/report/basic/report.php | 3 +++ mod/scorm/report/interactions/report.php | 2 ++ mod/scorm/report/objectives/report.php | 2 ++ 3 files changed, 7 insertions(+) diff --git a/mod/scorm/report/basic/report.php b/mod/scorm/report/basic/report.php index 899a858f79d4e..9f7a137fd545c 100644 --- a/mod/scorm/report/basic/report.php +++ b/mod/scorm/report/basic/report.php @@ -167,6 +167,9 @@ function display($scorm, $cm, $course, $download) { $table->no_sorting('start'); $table->no_sorting('finish'); $table->no_sorting('score'); + $table->no_sorting('checkbox'); + $table->no_sorting('picture'); + if ( $scoes ) { foreach ($scoes as $sco) { if ($sco->launch!='') { diff --git a/mod/scorm/report/interactions/report.php b/mod/scorm/report/interactions/report.php index 866101affd75f..a424d85eadd67 100644 --- a/mod/scorm/report/interactions/report.php +++ b/mod/scorm/report/interactions/report.php @@ -222,6 +222,8 @@ function display($scorm, $cm, $course, $download) { $table->no_sorting('start'); $table->no_sorting('finish'); $table->no_sorting('score'); + $table->no_sorting('checkbox'); + $table->no_sorting('picture'); for($id = 0; $id < $questioncount; $id++) { if ($displayoptions['qtext']) { diff --git a/mod/scorm/report/objectives/report.php b/mod/scorm/report/objectives/report.php index 38a6f57405297..4a4502783196a 100644 --- a/mod/scorm/report/objectives/report.php +++ b/mod/scorm/report/objectives/report.php @@ -237,6 +237,8 @@ public function display($scorm, $cm, $course, $download) { $table->no_sorting('start'); $table->no_sorting('finish'); $table->no_sorting('score'); + $table->no_sorting('checkbox'); + $table->no_sorting('picture'); foreach ($scoes as $sco) { if ($sco->launch != '') {