Set/get chunk property test EAR-1189 #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
commented
Aug 26, 2024
| } | ||
|
|
||
| prop_compose! { | ||
| pub fn metadata_and_indices()(metadata in zarr_array_metadata()) |
There was a problem hiding this comment.
this feels silly but I couldn't think of a better way. I miss the hypothesis data.draw construct.
There was a problem hiding this comment.
You could write an ArrayIndices strategy that takes a ZarrArrayMetadata strategy as argument
dcherian
changed the title
paraseba
approved these changes
Aug 26, 2024
| dataset.add_array(path.clone(), metadata.clone()).await.unwrap(); | ||
|
|
||
| dataset | ||
| .set_chunk_ref(path.clone(), indices.clone(), Some(payload1.clone())) |
There was a problem hiding this comment.
These days you can do set_chunk with bytes, instead of set_chunk_ref. Better because it will handle inline/materialized for you.
| } | ||
|
|
||
| prop_compose! { | ||
| pub fn metadata_and_indices()(metadata in zarr_array_metadata()) |
There was a problem hiding this comment.
You could write an ArrayIndices strategy that takes a ZarrArrayMetadata strategy as argument
dcherian
force-pushed
the
more-property-tests
branch
from
3edc666 to
2ec3abd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more commit from my testing spike last week. I didn't complete the stateful test bit but this could be useful with our new caching storage?