Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

jail + ce image #1

Closed
kaspar-allenbach opened this issue Dec 4, 2013 · 6 comments
Closed

jail + ce image #1

kaspar-allenbach opened this issue Dec 4, 2013 · 6 comments

Comments

@kaspar-allenbach
Copy link

Hi. I'm triyng out this jail thing. Its great so far.

One question tough:

I wrap a ce image tag inside jail.
This works perfectly. But I have one issue with the css class:

{exp:easy_jail:prep}
    {exp:ce_img:single src="{produkte_icon}" class="img-responsive" save_type="png"}
{/exp:easy_jail:prep}

This results in:

<img class="jail" src="/images/made/images/uploads/content_images/icon-dataset_270_270.png" style="display: inline;">
<noscript>
  <img src="/images/made/images/uploads/content_images/icon-dataset_270_270.png" class="img-responsive" width="270" height="270" alt=""/>
</noscript>

Is it possible to append the class "img-responsive" class on the img tag outside noscript and not just inside the noscript tag?

@aarongustafson
Copy link
Member

I’m currently traveling, but let me see what I can do when I get a moment
to sit down & look at it. Shouldn’t be hard.

On Wed, Dec 4, 2013 at 7:35 AM, Seppentoni [email protected] wrote:

Hi. I'm triyng out this jail thing. Its great so far.

One question tough:

I wrap a ce image tag inside jail.
This works perfectly. But I have one issue with the css class:

{exp:easy_jail:prep}
{exp:ce_img:single src="{produkte_icon}" class="img-responsive" save_type="png"}
{/exp:easy_jail:prep}

This results in:

Is it possible to append the class "img-responsive" class on the img tag
outside noscript and not just inside the noscript tag?


Reply to this email directly or view it on GitHubhttps://github.com//issues/1
.

@kaspar-allenbach
Copy link
Author

Is this plugin dead?

Jail also swallows the alt tag:

{exp:easy_jail:prep}
   {exp:ce_img:single src="{produkte_icon}" attributes='alt="The Cow"'}
{/exp:easy_jail:prep}

results in

<img class="jail" src="bla.jpg" alt="" style="display: inline;">
<noscript>
     <img src="bla.jpg" alt="">
</noscript>

@aarongustafson
Copy link
Member

Hmm, that’s not right. I will look into that today.

On Tue, Feb 11, 2014 at 8:53 AM, Seppentoni [email protected]:

Is this plugin dead?

Jail also swallows the alt tag:

{exp:easy_jail:prep}
{exp:ce_img:single src="{produkte_icon}" attributes='alt="The Cow"'}
{/exp:easy_jail:prep}

results in


Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-34755795
.

@kaspar-allenbach
Copy link
Author

Hi. Did you have time to look into it?

@aarongustafson
Copy link
Member

The alt fix is in. (I apologize, I got insanely busy.)

I will work on the other fix for appending the class too.

aarongustafson added a commit that referenced this issue Jan 29, 2015
@aarongustafson
Copy link
Member

Should be good now. Give it a shot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants