Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client class assumes we receive a XML as a response. #81

Open
imanoleguskiza opened this issue Aug 7, 2019 · 0 comments
Open

Client class assumes we receive a XML as a response. #81

imanoleguskiza opened this issue Aug 7, 2019 · 0 comments

Comments

@imanoleguskiza
Copy link
Contributor

On the send method of the EC\Poetry\Client we assume the response from the server is going to be an XML. This is a problem because if we don't (we receive an error string for example) we will trigger a Parsing Exception, which is not correct.

A solution would be to check if the response is a properly formatter XML and if it isn't simply return the string or throw an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant