Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated API #874

Open
1 of 8 tasks
Tracked by #871
jonahgraham opened this issue Jan 31, 2025 · 0 comments · May be fixed by #881
Open
1 of 8 tasks
Tracked by #871

Remove deprecated API #874

jonahgraham opened this issue Jan 31, 2025 · 0 comments · May be fixed by #881
Milestone

Comments

@jonahgraham
Copy link
Contributor

jonahgraham commented Jan 31, 2025

There are a few categories of deprecated API in LSP4J. Most of the @Deprecated annotations are applied to constructs that are deprecated in the LSP and DAP specifications.

Use git grep -p -n -A1 @Deprecated for a quick view of all the deprecated Java with some context.

  • Deprecated items still in LSP/DAP specs (not to be removed)

For example the LSP spec deprecated symbolInformation so it is marked as deprecated in LSP code. I assume cases like this should not be removed from LSP4J as we should keep in LSP4J the same as the spec.

This means not removing deprecated fields and classes in the xtend files and the various service classes (like LanguageServer)

There are numerous constructors in protocol files that are deprecated, such as one of the constructors of WorkspaceEditCapabilities

FormattingOptions getProperties and setProperties were deprecated in #99

Long deprecated and replaced with the more generic JsonRpcData

Items such as all the helper methods in Either seem to be easy decisions to remove

The various factories (like CollectionTypeAdapterFactory) seem to be easy decisions to remove

This was a misspelling and is easy to remove

This was deprecated already in #647 (comment)

@jonahgraham jonahgraham mentioned this issue Jan 31, 2025
37 tasks
@jonahgraham jonahgraham added this to the 1.0.0 milestone Jan 31, 2025
This was referenced Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant