From 926dbe5982f49bad83b22de23b716ee99bc8dd87 Mon Sep 17 00:00:00 2001 From: Kevin McDermott Date: Thu, 19 Mar 2020 17:41:56 +0000 Subject: [PATCH] If we have no default page or other options, respond with all items. --- scm/driver/fake/pr_test.go | 1 + scm/driver/fake/utils.go | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/scm/driver/fake/pr_test.go b/scm/driver/fake/pr_test.go index 9897eaa3c..a6208ea67 100644 --- a/scm/driver/fake/pr_test.go +++ b/scm/driver/fake/pr_test.go @@ -54,6 +54,7 @@ func TestPaginated(t *testing.T) { {2, 5, 10, 5, 10}, {2, 5, 9, 5, 9}, {4, 5, 10, 10, 10}, // this results in an empty slice + {0, 0, 10, 0, 10}, // this is the default 0 value for ListOption } for _, tt := range tests { diff --git a/scm/driver/fake/utils.go b/scm/driver/fake/utils.go index 8fd093018..31e876524 100644 --- a/scm/driver/fake/utils.go +++ b/scm/driver/fake/utils.go @@ -1,6 +1,13 @@ package fake func paginated(page, size, items int) (start, end int) { + // handle the default value case for ListOptions. + if page == 0 && size == 0 { + start = 0 + end = items + return + } + start = (page - 1) * size if start > items { start = items