Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large audiobook import => no UI feedback + "API" timeout in console (but eventually ... successful import) #1030

Closed
danielweck opened this issue Apr 30, 2020 · 6 comments

Comments

@danielweck
Copy link
Member

To reproduce, test with "Crimson Fairy Book LPF" (Lang_Crimson_Fairy_Book.lpf) from:

https://github.com/w3c/publ-tests/tree/master/test_content/audiobooks

...but remember to unzip, then re-zip the resources in order to fix the incorrect top folder. See: w3c/publ-tests#36

@danielweck
Copy link
Member Author

Note that W3C *.lpf format is converted during import, so this certainly contributes largely to the processing time, but we must also check that importing Readium Web Pub Manifest *.audiobook files provides minimum UI feedback, and no API timeout.

@panaC
Copy link
Member

panaC commented Apr 30, 2020

what UI do you want ? A simple toastInfo when lpfConvert has finished and passes the relay to importPublication ?

@panaC
Copy link
Member

panaC commented Apr 30, 2020

what takes the most time is a double copy of the zip archive. We can flag it to user between them

@danielweck
Copy link
Member Author

Note: this PR #930
adds a spinner indicator in the top-right corner during API background operations.

@panaC
Copy link
Member

panaC commented Oct 14, 2020

what do we do with this issue ? @danielweck @llemeurfr

@panaC panaC removed their assignment Oct 14, 2020
@danielweck
Copy link
Member Author

The console API timeout is only seen at development time, so I guess that's okay. The GUI progress indicator provides minimum feedback, so let's close this issue as it is not really actionable at this stage. We can always create a more narrow-focused issue later down the line, if long-running operations in Thorium remain problematic from a UX perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants